Add DKX (renamed from sfincs-jax) - #34466
Merged
Merged
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Contributor
Author
|
Windows fails because there are currently no jaxlib builds for win-64. |
Contributor
Author
|
@conda-forge/help-python, ready for review! |
matthewfeickert
requested changes
Aug 8, 2026
matthewfeickert
left a comment
Member
There was a problem hiding this comment.
Looks pretty good beyond some small revisions and needing all maintainers to sign off.
This is the latest release. Are any older releases needed as well?
5 tasks
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Contributor
Author
Not that I'm aware of. |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a recipe for
dkx, the renamed continuation ofsfincs-jax(existing feedstock: https://github.com/conda-forge/sfincs-jax-feedstock). Upstream renamed the project from sfincs_jax to DKX and now develops it at https://github.com/uwplasma/DKX. PyPIsfincs-jaxstops at 1.2.0 and PyPIdkxcontinues from 2.0.0, so conda-forge currently has no path forward for this package under the old name.The recipe is carried over from
sfincs-jax-feedstock'srecipe/recipe.yaml, which is already in the v1 format. This is a nearly pure rename; the changes are:sfincs-jax->dkx, version 1.2.0 -> 2.0.0, and the matching PyPI source URL and sha256sfincs_jaxinto a singledkx = dkx.cli:maindkx,dkx --help)abouthomepage and repository retargeted atuwplasma/DKX; documentation stays atsfincs-jax.readthedocs.io, which is where upstream'spyproject.tomlstill publishes the renamed project's docs (dkx.readthedocs.iobelongs to an unrelated project)The dependency set (
jax,numpy,scipy,h5py,netcdf4,matplotlib-base,solvax),noarch: python, and thepip_checktest are unchanged from the reviewedsfincs-jaxrecipe, matching upstream's unchanged runtime metadata.Once this merges I will open an issue on
conda-forge/sfincs-jax-feedstockand follow it with an archive request inconda-forge/admin-requests, so the old feedstock stops presenting 1.2.0 as current.Built and tested locally with
rattler-build build --recipe recipes/dkx/recipe.yaml --variant-config <python_min pinning> -c conda-forgebefore submitting.Checklist
recipe.yamlformat, or this PR explains the exceptional requirement for deprecated v0.url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).