Add VMEX (renamed from vmec-jax) - #34465
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Windows fails because there are currently no jaxlib builds for win-64. |
|
@conda-forge/help-python, ready for review! |
matthewfeickert
left a comment
There was a problem hiding this comment.
Looks pretty good beyond some small revisions and needing all maintainers to sign off.
|
@RKHashmani this is |
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
To my knowledge, no. Nothing in driftless-star needs anything prior, since v0.4.0 is a strict superset. |
This adds a recipe for
vmex, the renamed continuation ofvmec-jax(existing feedstock: https://github.com/conda-forge/vmec-jax-feedstock). Upstream renamed the project from vmec_jax to VMEX and now develops it at https://github.com/uwplasma/vmex. PyPIvmec-jaxstops at 0.1.0 and PyPIvmexcontinues from 0.2.0 (currently 0.4.0), so conda-forge currently has no path forward for this package under the old name.The recipe is carried over from
vmec-jax-feedstock'srecipe/recipe.yaml, which is already in the v1 format. The changes are:vmec-jax->vmex, version 0.1.0 -> 0.4.0, and the matching PyPI source URL and sha256vmec+vmec-jaxwithvmex+vmec, both pointing atvmex.core.cli:main(vmecis kept as an alias)setuptools >=77inhost, because upstream'spyproject.tomlnow uses PEP 639 (license = "MIT"pluslicense-files) and older setuptools does not emit that metadatapackagingadded tohost, since upstream's[build-system]requires it and the recipe builds with--no-build-isolation(it stays inrunas before, where upstream also declares it)jaxlibadded torun, since upstream declares it directly andpip_checkreads the distribution metadatasolvax >=0.8.8, matching the bound upstream's metadata declares;booz-xform-jaxis now unbounded, also matching upstream, which dropped the>=0.1.1floor the old recipe carriedvmexandvmec_jax— upstream ships avmec_jaxdeprecation shim for one release so old imports keep workingaboutURLs retargeted at the renamed project: homepage and repository point atuwplasma/vmex, documentation atvmex.readthedocs.ionoarch: python, thematplotlib-basedependency, the unconditionaltomli, and thepip_checkplus CLI smoke tests are unchanged from the reviewedvmec-jaxrecipe.Once this merges I will open an issue on
conda-forge/vmec-jax-feedstockand follow it with an archive request inconda-forge/admin-requests, so the old feedstock stops presenting 0.1.0 as current.Built and tested locally with
rattler-build build --recipe recipes/vmex/recipe.yaml --variant-config <python_min pinning> -c conda-forgebefore submitting.Checklist
recipe.yamlformat, or this PR explains the exceptional requirement for deprecated v0.url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).