Add GKX (renamed from spectraxgk) - #34462
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/gkx/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/31213239674. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
I addressed the linter's Windows fails because there are currently no jaxlib builds for win-64. |
|
@conda-forge/help-python, ready for review! |
matthewfeickert
left a comment
There was a problem hiding this comment.
Looks pretty good beyond some small revisions and needing all maintainers to sign off.
(This is also basically a direct port of https://github.com/conda-forge/spectraxgk-feedstock/blob/7aaf335d4fa426f6b6e61706aafed974b1351fe7/recipe/recipe.yaml which makes it easy 👍)
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
|
@RKHashmani Thanks for contributing your first recipe to conda-forge! If you aren't already, we'd encourage you to join the conda-forge Zulip server to ask questions and engage with the broader community. |
This adds a recipe for
gkx, the renamed continuation ofspectraxgk(existing feedstock: https://github.com/conda-forge/spectraxgk-feedstock). Upstream renamed the project from SPECTRAX-GK to GKX and now develops it at https://github.com/uwplasma/GKX. PyPIspectraxgkstops at 1.7.0 and PyPIgkxcontinues from 1.7.1, so conda-forge currently has no path forward for this package under the old name.The recipe is carried over from
spectraxgk-feedstock'srecipe/recipe.yaml, which is already in the v1 format. The changes are:spectraxgk->gkx, version 1.7.0 -> 1.7.1, and the matching PyPI source URL and sha256spectrax-gkandspectraxgkinto a singlegkx = gkx.cli:mainsetuptools >=77inhost, because upstream'spyproject.tomlnow uses PEP 639 (license = "MIT"pluslicense-files = ["LICENSE"]) and older setuptools does not emit that metadatajaxlibadded torun, since upstream declares it directly andpip_checkreads the distribution metadatasolvaxis now unbounded, matching the 1.7.1 sdist metadata, which dropped the>=0.7.3,<0.8bound the old recipe carried (upstreammainhas since added>=0.12.0, which will flow into the recipe with the next release)aboutsummary, description and URLs retargeted at the renamed project: homepage and repository now point atuwplasma/GKX, and documentation moved fromspectrax-gk.readthedocs.iotogkx.readthedocs.ionoarch: python, thematplotlib-basedependency, the unconditionaltomli, and thepip_checkplus CLI smoke test are unchanged from the reviewedspectraxgkrecipe.Once this merges we will open an issue on
conda-forge/spectraxgk-feedstockand follow it with an archive request inconda-forge/admin-requests, so the old feedstock stops presenting 1.7.0 as current.Built and tested locally with
rattler-build build --recipe recipes/gkx/recipe.yaml -c conda-forgebefore submitting.Checklist
recipe.yamlformat, or this PR explains the exceptional requirement for deprecated v0.url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).