Skip to content

Add pyqir - #33156

Merged
wolfv merged 8 commits into
conda-forge:mainfrom
basnijholt:add-pyqir
Jun 6, 2026
Merged

Add pyqir#33156
wolfv merged 8 commits into
conda-forge:mainfrom
basnijholt:add-pyqir

Conversation

@basnijholt

Copy link
Copy Markdown
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Notes

  • Upstream package tested locally from the PyPI wheel: pip check, a QIR generation/bitcode round-trip smoke test, selected examples, and the full upstream Python test suite (257 passed).
  • Recipe tested locally on osx-arm64 with conda-build using maturin 1.10.2: pip check, smoke test, and upstream Python test suite (257 passed).
  • I confirm I am willing to be listed as a recipe maintainer as basnijholt.

@basnijholt

basnijholt commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

@conda-forge/help-python-c, ready for review!

@conda-forge-admin

conda-forge-admin commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyqir/recipe.yaml) and found it was in an excellent condition.

Comment thread recipes/pyqir/meta.yaml Outdated
@basnijholt

basnijholt commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

@conda-forge/help-python and perhaps @conda-forge/help-rust, could someone please take a look here and approve/merge if it looks good?

All is tested locally on both Linux and macOS.

Some folks I am helping out are blocked by this. Specifically conda-lock doesn't work with the PyPI version of pyqir because of glib 2.34, see qir-alliance/pyqir#355 and conda/conda-lock#900.

Comment thread recipes/pyqir/recipe.yaml
Comment thread recipes/pyqir/build.bat Outdated
Comment thread recipes/pyqir/recipe.yaml Outdated
Comment thread recipes/pyqir/recipe.yaml
Comment thread recipes/pyqir/recipe.yaml Outdated
@basnijholt
basnijholt requested review from bollwyvl, isuruf and wolfv May 22, 2026 17:00
@basnijholt

Copy link
Copy Markdown
Contributor Author

@bollwyvl @wolfv @isuruf, I addressed all your comments (2 weeks ago 😃) would you mind re-reviewing / approving? Thanks a lot!

Comment thread recipes/pyqir/recipe.yaml Outdated
Comment thread recipes/pyqir/recipe.yaml Outdated
@basnijholt

Copy link
Copy Markdown
Contributor Author

Thanks @bollwyvl for another look. I address both comments and CI is passing still 😃

@basnijholt
basnijholt requested a review from bollwyvl June 5, 2026 18:01
@wolfv
wolfv merged commit 56bca4c into conda-forge:main Jun 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants