Add gtsam-points - #33149
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/25052840041. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
GPU tests are failing in the docker image used to build the recipe, I'm not sure how to fix this. I will disable tests on CUDA build since the feedstock will not have GPU runners in any case. |
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/25059061746. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@koide3 I'm packaging |
|
@conda-forge/help-c-cpp, ready for review! |
There was a problem hiding this comment.
Pull request overview
Adds a conda-forge staged recipe for gtsam-points (GTSAM point-cloud SLAM factors/optimizers), including CUDA-optional builds and an unvendoring patch to rely on the packaged nanoflann.
Changes:
- Introduces a new
recipes/gtsam-points/recipe.yamlwith split outputs (gtsam-pointsandgtsam-points-devel) and optional CUDA support. - Adds
001-unvendor-nanoflann.patchto remove vendored nanoflann usage and switch tofind_package(nanoflann)/find_dependency(nanoflann).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| recipes/gtsam-points/recipe.yaml | New recipe defining build/test steps, dependencies, and split outputs (including CUDA-conditional pieces). |
| recipes/gtsam-points/001-unvendor-nanoflann.patch | Patch to unvendor nanoflann and update KD-tree implementation and CMake dependency wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
db50343 to
7f1af2e
Compare
This PR adds https://github.com/koide3/gtsam_points, a collection of GTSAM factors and optimizers for point cloud SLAM.
It is needed by the following package, and I iterated directly in that PR before moving it here:
glim#33137Considering this is a complex recipe with cuda support, I thought it was better to get a review and run CI separately.
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).