add recipe for finch-tensor - #32124
Conversation
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-python-c ready for review, thanks! |
|
thanks Lucas! do you need the other PR merged to merge this one? |
nope I think this is ready and standalone! Just waiting for a review from @conda-forge/help-python-c. |
|
@lucascolley Can you add Willow and me as recipe maintainers? |
traversaro
left a comment
There was a problem hiding this comment.
Can you explain why this is not noarch: python and why it can't depend on c-compiler?
There were some test failures on Windows, let me make that change now for demonstration |
|
If the package itself does not support Windows (that seems the case to me) you can also just add a run dependency on |
this requires reverting the |
can you advise @willow-ahrens @mtsokol ? Indeed we are seeing some windows failures over in finch-tensor/finch-tensor#314 |
|
the windows failure is related to the optional c-compiler dep right? It sounds like we should make the c-compiler tests opt-in somehow so to reflect the fact that the default numba backend is cross-platform. |
I'll mark this as draft until that is done |
|
The c compiler tests are opt-in now. we have different test groups for with or without c |
|
@willow-ahrens @mtsokol ready for a look |
|
OSX failure for the Julia backend: |
| - pyjuliapkg >=0.1.16,<0.2.0 | ||
| - pyjuliacall >=0.9.24,<0.10.0 |
There was a problem hiding this comment.
hey @conda-forge/help-julia, should we be including a dependency on the julia package perhaps?
There was a problem hiding this comment.
I think these dependencies are sufficient unless you have specific issue.
There was a problem hiding this comment.
I think these dependencies are sufficient unless you have specific issue.
there was an issue: #32124 (comment)
b112489 to
e48dd26
Compare
|
hey @traversaro, could you possibly take another look? |
|
Besides the Windows CI failures, the recipe seems good to me. |
Any idea what's up there? |
I guess that perhaps some process started by the tests is not properly closed at the end of the tests? |
@willow-ahrens @mtsokol @hameerabbasi any guesses? |
|
You are in luck because I also happen to be the HDF5.jl maintainer. At the moment, I cannot figure out why libhdf5 would need to load the Fortran library for Julia. I suspect that more than one library may be trying to access HDF5. We have a few options, including pointing to the conda-forge HDF5 libraries. |
Could be the C compiler/linker; I can't think of any other external processes. |
|
let's return to this once prefix-dev/rattler-build#2729 is released |
https://github.com/finch-tensor/finch-tensor
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).