Add SOFA supported plugins - #31892
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sofa-app/recipe.yaml:
For recipes/sofa-glfw/recipe.yaml:
For recipes/sofa-stlib/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20899426208. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
I want to be a co-maintainer of this package. |
|
So do I |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-c-cpp @conda-forge/help-python this is ready for review |
|
Bumping, if anybody has a bit of time to review / merge this, would be huge help ! Thanks ! |
|
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-c-cpp and so here I am doing that. |
|
@conda-forge/help-c-cpp Could someone review / merge this ? I know the PR is quite big... Thanks a lot for those who will have time for it |
|
It may take a bit to review all of this but two things to start:
|
|
Thanks so much for your review @danielnachun.
|
|
The CI is failing as it looks like there is a multi-recipe build order resolution bug in rattler-build. It outputs to build |
|
Locally, I reproduce the bug of bad build order for multi-recipe using |
e1bb09f to
5e19656
Compare
|
Now it is running fine with |
Thanks for the careful explanation, these are indeed blockers to unvendoring. It sounds like for |
fa9934e to
f85047b
Compare
|
Thanks a lot @olivier-roussel @bakpaul @hugtalbot , and sorry for the delay in the review. The PR seems fine for me, it is ok for me to rebase the branch on top of latest main, or you want to do it yourself? |
|
@traversaro Thanks a lot for your review ! I've just updated the branch, let's wait for the CI |
This adds multiple packages for the officially supported plugins for SOFA by upstream. SOFA core package has been recently merged and is already available on CF. The initial staged-recipes PR which was containing both SOFA core and plugins has been splitted, and this PR is the second part for the supported plugins, updated since it has been initiated more than 2 years ago.
Most of these packages have inter-dependencies so they are submitted in this one single PR. Sorry, it makes it quite big, but at least these recipes are mostly similar. IMO, the only case that deserves particular attention is
sofa-glfw(see below).Here are the included packages:
sofa-python3: SOFA plugin - Python bindings for SOFA core & Python scene description supportsofa-modelorderreduction: SOFA plugin - Plugin to reduce models. C++ with Python bindings.sofa-beamadapter: SOFA plugin - Kirchhoff rods to simulate any 1D flexible structure. C++ library.sofa-stlib: SOFA plugin - SOFA Template Library containing SOFA scenes templates. Python only.sofa-cosserat: SOFA plugin - Plugin to simulate linear structures using Cosserat theory. C++ with Python bindings.sofa-softrobots: SOFA plugin - Components & method for soft robotics. C++ with Python bindings.sofa-softrobotsinverse: SOFA plugin - Inverse control method for soft robotics. C++ with Python bindings.sofa-glfw: SOFA plugin - Quick and simple GUI for SOFA, based on GLFW and Dear ImGui. C++ with Python bindings.sofa-app: GUI executable based onsofa-glfwpluginSpecial notes for
sofa-glfw:This plugin does vendor some code, which is not redistributed in the package, only used at compile-time. We could not find a satisfactory solution for the
imguivendored code. This is because imgui upstream have made the choice to manage two versions (through two branches) ofimgui:masteranddocking(which contains some advanced features). Currentimguiconda package does not include thedockingversion, andsofa-glfwis using thisdockingbranch at relies on its Docking advanced features. As already discussed withimguiconda package maintainers (conda-forge/imgui-feedstock#22), keeping vendoring code here may sound reasonable in such case, due to the lack of alternatives.Other vendored dependencies in
sofa-glfware:implotexists but it relies onimguipackage, which is themasterbranch version ofimgui, and not thedockingone we need (as explained above).Licenses have been included to the package.
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).