Add UDA - #30647
Conversation
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/uda/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19225001569. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and I found some lint. It looks like some changes were made outside the If these changes are intentional (and you aren't submitting a recipe), please add a File-specific lints and/or hints:
|
This reverts commit 4e67e40.
…include it as a dependency for Unix systems
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/xdr/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19231930660. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…dr as a dependency in recipe.yaml
|
@traversaro I believe this PR is ready to be merged. Could you kindly provide final confirmation? |
| - ninja | ||
| - pkg-config | ||
| host: | ||
| - libxml2 |
There was a problem hiding this comment.
This should be libxml2-devel
There was a problem hiding this comment.
I changed to libxml2-devel 2.14.* because the pinning version in conda-forge-pinning is not available on the conda-forge repo.
| run: | ||
| - if: linux and x86_64 | ||
| then: libtirpc | ||
| ignore_run_exports: |
There was a problem hiding this comment.
Can you explain why you can ignore these run_exports?
There was a problem hiding this comment.
Because ratter-build warned that they were over-linking.
Honestly, the current build script includes nearly all wrapper builds, since I ported it from the previous cache build.
Therefore, Python is not required as a run-time dependency for this core package.
According to the source codes, the rest of them are required when creating object files as PRIVATE and are not specified when creating the shared library.
So, I just omitted them from runtime deps.
| - zlib | ||
| - dlfcn-win32 | ||
| run_exports: | ||
| - ${{ pin_subpackage("libuda-client", upper_bound="x.x") }} |
There was a problem hiding this comment.
Are you sure that the ABI does not change on patch releases?
There was a problem hiding this comment.
Presumably, patch releases usually happen when applying bug fixes.
So it should work
| - cmake | ||
| - ninja | ||
| run_exports: | ||
| - ${{ pin_subpackage('portablexdr', upper_bound='x.x') }} |
There was a problem hiding this comment.
Are you sure that the ABI does not change on patch releases?
There was a problem hiding this comment.
I changed to exact pinning.
|
Thanks @munechika-koyo ! |
|
@traversaro Thank you for your continued support! |
* Add UDA recipe and build scripts for multiple platforms * Add tests for C++ and Java clients in UDA recipe * Remove pip and setuptools from build requirements for cross-compile * fix symlink for UDA jar file in Java client output * Set experimental build flag for Rattler in build scripts * Add patches for no cast function type and CLI help improvements * Revert "Set experimental build flag for Rattler in build scripts" This reverts commit 4e67e40. * Add experimental flag to Rattler build command * Fix Java JAR filename format in recipe.yaml * Fix python version for cache build because of no need to compile for python variant * Enable LibMemcached in CMake configuration and update recipe.yaml to include it as a dependency for Unix systems * Add udaClient.patch to fix the error at `udaClient.cpp` * add exclude files for python-related path * Add libmemcached as a runtime requirement for Unix systems * Add libtirpc as a runtime requirement for Linux x86_64 systems * Update test outputs to include pkgconfig file for C++ client * Add libxml2 at python build * Add stdlib requirement for build in recipe.yaml * Add configuration and build steps for Portable XDR in build_cache.bat * Fix typo in cmake command in build_cache.bat * Add `dlfcn-win32` dependency for Windows builds in recipe.yaml * Add CMake policy version minimum for Portable XDR configuration * Fix build paths for Portable XDR and UDA client in build_cache.bat * Add patch for `error: variable 'num_cached' set but not used` * Add environment variable setup for UDA client in build_cache.bat * Move environment variable settings for UDA client to cmake command in build_cache.bat * Add `zlib` to Windows dependencies in recipe.yaml * Update UDA client build configuration to use library variables for paths * Update build_cache.bat to use LIBRARY_PREFIX for installation paths * Disable MinGW for UDA client build configuration * Revert "Disable MinGW for UDA client build configuration" This reverts commit 97658e3. * Fix build configuration for Portable XDR and UDA client by ensuring shared libraries are disabled and specifying correct library paths. * Remove conditional Python requirements for cross-platform builds for cache phase * Refine Windows-specific library exclusions and installation scripts in UDA recipe * Add Windows-specific dependencies for cache and outputs in UDA recipe * Update libboost dependency to libboost-devel in UDA recipe * add libboost and capnproto to ignore_run_exports for better dependency management * Refactor CMake configuration in build scripts to remove redundant prefix paths * Enable shellcheck for improved shell script linting in conda-forge.yml * Update upper bound version pinning for run_exports in UDA recipe * Fix quoting in Windows installation commands for Python installer * Fix quoting for SRC_DIR in build_cache.sh to ensure proper path handling * Revert "Enable shellcheck for improved shell script linting in conda-forge.yml" This reverts commit e1dc9af. * Fix variable interpolation for Python installation commands in recipe.yaml * Fix package_contents test * Remove runtime dependency on libmemcached because it's exported from host deps * Remove CMAKE_INSTALL_PREFIX from build_cache.bat to avoid overriding default installation path * Remove CMAKE_BUILD_TYPE from build_cache.bat, which is given by `%CMAKE_ARGS%` * Add improve_install_destination.patch to enhance installation paths in CMake * Add fix_win_setup_py.patch to recipe.yaml for Windows setup improvements * Update recipe.yaml to include python library * Remove exclusion of all files in Python client installation * integrate some patches into one patch * Remove fix_win_setup_py.patch from patches and update output exclusions for Windows static libraries * Refactor output specifications for Java client by removing Windows-specific DLL entry and simplifying library references * Update Python client output specifications to differentiate package paths for Unix and Windows * Update improve_install_destination.patch to refine installation paths in CMake * Add shared serialisation patch and update recipe outputs for dependencies * Update add_shared_serialisation.patch to include shared library build options and installation settings * Update recipes/uda/recipe.yaml Co-authored-by: Silvio Traversaro <silvio@traversaro.it> * 🚚 Move and remove patches and scripts * Fix UDA build configuration by ensuring UDA_PYTHON_SHARED is set and maintaining IDL wrapper settings * Add patch for UDA to address build issues * Update UDA recipe to version 2.9.1 and simplify the recipe * Remove experimental flag from build_folders_rattler_build function * Add build number to its section * Rename patch reference from 'fix-conda-forge#83.patch' to 'pr-conda-forge#83.patch' in UDA recipe * Update output exclusions and add package contents test in UDA recipe * Fix patch reference in UDA recipe from 'pr-conda-forge#83.patch' to 'pr-83.patch' * Add CMake support for xdr recipe * Uncomment stdlib('c') requirement in xdr recipe * Fix patch file name * Add tests section to xdr recipe for package contents verification * Update package name and source URL in xdr recipe for consistency * Fix run_exports to pin the correct subpackage name in xdr recipe * Add skip directive for unix in xdr * Fix indentation in build script for consistency * Rename directory * Add disable-sys-time-include.patch to the portablexdr recipe * Remove Portable XDR build steps from build_core.bat and add portablexdr as a dependency in recipe.yaml * Add CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS option to build script * Revert "Add disable-sys-time-include.patch to the portablexdr recipe" This reverts commit 92bf468. * Add port-from-uda.patch to the portablexdr recipe * Add comments to clarify the purpose of patches in recipe.yaml * Disable LibMemcached in build configuration and remove related patch from recipe.yaml * Remove add_log_memcached.patch from uda recipe * Remove no_cast_function_type.patch from UDA recipe * Update portablexdr recipe to pin subpackage version exactly * Update UDA recipe to specify libxml2-devel version for host requirements --------- Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
* Add UDA recipe and build scripts for multiple platforms * Add tests for C++ and Java clients in UDA recipe * Remove pip and setuptools from build requirements for cross-compile * fix symlink for UDA jar file in Java client output * Set experimental build flag for Rattler in build scripts * Add patches for no cast function type and CLI help improvements * Revert "Set experimental build flag for Rattler in build scripts" This reverts commit 4e67e40. * Add experimental flag to Rattler build command * Fix Java JAR filename format in recipe.yaml * Fix python version for cache build because of no need to compile for python variant * Enable LibMemcached in CMake configuration and update recipe.yaml to include it as a dependency for Unix systems * Add udaClient.patch to fix the error at `udaClient.cpp` * add exclude files for python-related path * Add libmemcached as a runtime requirement for Unix systems * Add libtirpc as a runtime requirement for Linux x86_64 systems * Update test outputs to include pkgconfig file for C++ client * Add libxml2 at python build * Add stdlib requirement for build in recipe.yaml * Add configuration and build steps for Portable XDR in build_cache.bat * Fix typo in cmake command in build_cache.bat * Add `dlfcn-win32` dependency for Windows builds in recipe.yaml * Add CMake policy version minimum for Portable XDR configuration * Fix build paths for Portable XDR and UDA client in build_cache.bat * Add patch for `error: variable 'num_cached' set but not used` * Add environment variable setup for UDA client in build_cache.bat * Move environment variable settings for UDA client to cmake command in build_cache.bat * Add `zlib` to Windows dependencies in recipe.yaml * Update UDA client build configuration to use library variables for paths * Update build_cache.bat to use LIBRARY_PREFIX for installation paths * Disable MinGW for UDA client build configuration * Revert "Disable MinGW for UDA client build configuration" This reverts commit 97658e3. * Fix build configuration for Portable XDR and UDA client by ensuring shared libraries are disabled and specifying correct library paths. * Remove conditional Python requirements for cross-platform builds for cache phase * Refine Windows-specific library exclusions and installation scripts in UDA recipe * Add Windows-specific dependencies for cache and outputs in UDA recipe * Update libboost dependency to libboost-devel in UDA recipe * add libboost and capnproto to ignore_run_exports for better dependency management * Refactor CMake configuration in build scripts to remove redundant prefix paths * Enable shellcheck for improved shell script linting in conda-forge.yml * Update upper bound version pinning for run_exports in UDA recipe * Fix quoting in Windows installation commands for Python installer * Fix quoting for SRC_DIR in build_cache.sh to ensure proper path handling * Revert "Enable shellcheck for improved shell script linting in conda-forge.yml" This reverts commit e1dc9af. * Fix variable interpolation for Python installation commands in recipe.yaml * Fix package_contents test * Remove runtime dependency on libmemcached because it's exported from host deps * Remove CMAKE_INSTALL_PREFIX from build_cache.bat to avoid overriding default installation path * Remove CMAKE_BUILD_TYPE from build_cache.bat, which is given by `%CMAKE_ARGS%` * Add improve_install_destination.patch to enhance installation paths in CMake * Add fix_win_setup_py.patch to recipe.yaml for Windows setup improvements * Update recipe.yaml to include python library * Remove exclusion of all files in Python client installation * integrate some patches into one patch * Remove fix_win_setup_py.patch from patches and update output exclusions for Windows static libraries * Refactor output specifications for Java client by removing Windows-specific DLL entry and simplifying library references * Update Python client output specifications to differentiate package paths for Unix and Windows * Update improve_install_destination.patch to refine installation paths in CMake * Add shared serialisation patch and update recipe outputs for dependencies * Update add_shared_serialisation.patch to include shared library build options and installation settings * Update recipes/uda/recipe.yaml Co-authored-by: Silvio Traversaro <silvio@traversaro.it> * 🚚 Move and remove patches and scripts * Fix UDA build configuration by ensuring UDA_PYTHON_SHARED is set and maintaining IDL wrapper settings * Add patch for UDA to address build issues * Update UDA recipe to version 2.9.1 and simplify the recipe * Remove experimental flag from build_folders_rattler_build function * Add build number to its section * Rename patch reference from 'fix-conda-forge#83.patch' to 'pr-conda-forge#83.patch' in UDA recipe * Update output exclusions and add package contents test in UDA recipe * Fix patch reference in UDA recipe from 'pr-conda-forge#83.patch' to 'pr-83.patch' * Add CMake support for xdr recipe * Uncomment stdlib('c') requirement in xdr recipe * Fix patch file name * Add tests section to xdr recipe for package contents verification * Update package name and source URL in xdr recipe for consistency * Fix run_exports to pin the correct subpackage name in xdr recipe * Add skip directive for unix in xdr * Fix indentation in build script for consistency * Rename directory * Add disable-sys-time-include.patch to the portablexdr recipe * Remove Portable XDR build steps from build_core.bat and add portablexdr as a dependency in recipe.yaml * Add CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS option to build script * Revert "Add disable-sys-time-include.patch to the portablexdr recipe" This reverts commit 92bf468. * Add port-from-uda.patch to the portablexdr recipe * Add comments to clarify the purpose of patches in recipe.yaml * Disable LibMemcached in build configuration and remove related patch from recipe.yaml * Remove add_log_memcached.patch from uda recipe * Remove no_cast_function_type.patch from UDA recipe * Update portablexdr recipe to pin subpackage version exactly * Update UDA recipe to specify libxml2-devel version for host requirements --------- Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).