Adding temporalio - #30569
Conversation
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/temporalio/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16380234400. Examine the logs at this URL for more detail. |
The output related to the `maturin` and Rust compilation, as well as protobufs.
|
I am willing to be a maintainer. |
|
willing to help maintain |
|
I can help maintain! |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-python ready to review! Can someone advise on how I can verify if this PR passes the two "static libraries" items on the checklist? I'm new to contributing to conda-forge and am not 100% clear on how to make sure of this. Thanks! |
danielnachun
left a comment
There was a problem hiding this comment.
I've suggested some changes to get the third party license information added to the recipe output.
This concern doesn't apply here because the native code is producing a shared library as seen in the build logs - it ends in |
|
@xhochy I'm not sure this is a blocker, but do we have a way to get auditable binaries for a Python package with embedded Rust like this? It is becoming increasingly common for Python, NodeJS and even C/C++ projects to embed Rust code and it's not terribly clear to me yet how we can make sure the generated binaries are auditable. |
|
At least for My aim is to push that CFEP in September. |
Co-authored-by: Daniel Nachun <daniel.nachun@gmail.com>
That's good to know. I guess ideally build systems will respect |
|
Thanks for the review @danielnachun , I incorporated and adapted your suggested change & saw this pass locally with linux64. However, it seems to have failed in the linux64 Azure pipeline with a 502 error when downloading one of the dependencies – maybe this is intermittent & it's worth retrying the pipeline? It also failed during the win64 build when the worker ran out of disk space, but I'm not sure what to do about that. What would you advise? |
|
@conda-forge/help-rust Pinging a slightly larger crowd here, I believe @chrisjryan's comment is accurate based off a review of the logs. |
|
Hi @danielnachun and @conda-forge/help-rust , just checking in again. Do you have any advice around our questions in the comments above? |
|
Make a new commit to skip Windows - that should also rerun the CI and hopefully get past the transient issue that failed last time on Linux. |
|
Hi again @danielnachun , just checking back in in case you have time to review. Your suggested change from last week has allowed test to pass. |
danielnachun
left a comment
There was a problem hiding this comment.
Just one minor tweak and then we can merge.
since Python 3.8 is no longer supported anyway Co-authored-by: Daniel Nachun <daniel.nachun@gmail.com>
|
@danielnachun Tweak added! Thanks again for the help. |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).