Skip to content

Add recipe for natu - #11075

Closed
johnflavin wants to merge 2 commits into
conda-forge:masterfrom
johnflavin:natu
Closed

Add recipe for natu#11075
johnflavin wants to merge 2 commits into
conda-forge:masterfrom
johnflavin:natu

Conversation

@johnflavin

Copy link
Copy Markdown

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

Comment thread recipes/natu/meta.yaml

about:
home: http://kdavies4.github.io/natu/index.html
license_file: LICENSE.txt

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add license and license_family entries

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know what to include for those. The license text doesn't make reference to any particular named license or license family that I know of. https://github.com/kdavies4/natu/blob/master/LICENSE.txt

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a modified BSD license. However, the last clause makes me think we can't redistribute this:

This software is controlled under the jurisdiction of the United States
      Department of Commerce and subject to Export Administration Regulations.
      By downloading or using the Software, you are agreeing to comply with
      U. S. export controls.  Diversion contrary to law is prohibited.  The
      software cannot be exported or reexported to sanctioned countries that
      are controlled for Anti-Terrorism (15 CFR Part 738 Supplement 1) or to
      denied parties

CC @conda-forge/core This is something that would be have been caught by conda-forge/conda-smithy#1256

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added BSD for both license and license_family. Leaving aside for the moment the issue of whether this package is redistributable, are these the correct values? Is there some way to indicate in the license value that the license is a modified BSD, and not just BSD?

@scopatz scopatz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license

@isuruf

isuruf commented Mar 16, 2020

Copy link
Copy Markdown
Member

@conda-forge-admin, lint

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/natu) and found some lint.

Here's what I've got...

For recipes/natu:

  • The license item is expected in the about section.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/natu) and found it was in an excellent condition.

@johnflavin

Copy link
Copy Markdown
Author

I asked the author of natu about the potential for modifying the license in kdavies4/natu#36. But given that this ticket was opened years ago, and the author responded that he didn't have time to work on it, I have little hope that the situation will be addressed. I'll close this PR.

@johnflavin johnflavin closed this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants