fix: add run export and minor other cleanups - #4
Merged
Conversation
- add run_export so that downstream packages have it at runtime automatically (and also avoids ABI missmatches my pinning ABI semver). - refactor to better recipe v1 test syntaxes - add about.repository link
ndeybach
commented
May 2, 2026
ndeybach
left a comment
ndeybach
left a comment
Contributor
Author
There was a problem hiding this comment.
@conda-forge-admin, please rerender
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Contributor
Author
|
@conda-forge-admin, please rerender |
![conda-forge-webservices[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Contributor
Author
|
Do you think this is mergeable ? Or do you have remarks on the matters addressed ? |
Since the dll and .lib is not versioned, it should be simplifyable.
From the pystring [packaged shared libs](https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Fpystring-1.1.5-h171cf75_0.conda) it seems that the soversion / ABI change is targetted at majors mainly : ``` include/pystring/pystring.h lib/libpystring.so lib/libpystring.so.1 lib/libpystring.so.1.1.4 ``` Hence unconstraining the run_exports seems pertinent.
Contributor
|
Thanks @ndeybach! 🙏 |
ndeybach
added a commit
to ndeybach/openimageio-feedstock
that referenced
this pull request
May 7, 2026
Since conda-forge/pystring-feedstock#4 was merged with added run_exports for pystring, we can remove the ones in this feedstock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)add run_export so that downstream packages have it at runtime automatically (and also avoids ABI missmatches my pinning ABI semver).
refactor to better recipe v1 test syntaxes
add about.repository link