openusd v26.08 - #33
Open
regro-cf-autotick-bot wants to merge 5 commits into
Open
Conversation
regro-cf-autotick-bot
requested review from
oursland and
traversaro
as code owners
July 20, 2026 23:53
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/29893058704. Examine the logs at this URL for more detail. |
fix_tbb_version_macro.patch failed to apply (hunk conda-forge#1 context not found): 26.08 restructured pxr/base/work/workTBB to include a new local header tbb_version.h, which uses __has_include to pull in <tbb/version.h> (or the legacy tbb/tbb_stddef.h) and #errors if TBB_INTERFACE_VERSION_MAJOR is still undefined. That supersedes the downstream patch, so remove it. 3759.patch (upstream PR #3759, pxrConfig.cmake.in Python version pin) is merged into 26.08 and was already being skipped as "already applied"; remove it as well.
Two 26.08 regressions surfaced once the patch-application failure was resolved: 1. ctest reported "No tests were found!!!" and failed the build. On some configurations (e.g. linux_64) OpenUSD registers no ctest tests at all; older ctest treated that as success (v26.05 logged the same message and passed), but recent ctest defaults the no-tests action to "error". Pass --no-tests=ignore to restore the prior behavior without masking real test failures on configurations that do register tests. 2. OpenUSD 26.08 added PXR_PYTHON_INSTALL_DIR, which now defaults to a lib/pythonX.Y/site-packages (Lib\site-packages on Windows) layout instead of the previously hard-coded lib/python. That breaks the "mv/move lib/python/pxr -> SP_DIR" step in build.sh/build.bat. Pin PXR_PYTHON_INSTALL_DIR=lib/python to keep the expected layout.
On macOS, OpenUSD 26.08 fails 195 of 991 ctest tests, all standalone C++
test executables aborting at load with missing Python symbols, e.g.:
dyld: symbol not found in flat namespace '__Py_NoneStruct'
conda-forge's Python reports a static LDLIBRARY (libpythonX.Y.a) via
sysconfig, so OpenUSD force-enables PXR_PY_UNDEFINED_DYNAMIC_LOOKUP. In
that mode the USD C++ libraries reference Python C-API symbols (TfPython,
boost::python glue) that are left undefined for runtime resolution, and
libpython is only meant to be linked into EXECUTABLE targets. The existing
link_python_to_executables.patch wires that up for the boost python
interface target, but the executables built by pxr_build_test link only
their explicit ${bt_LIBRARIES} and never pull in ${PYTHON_LIBRARIES}, so
they load without libpython and cannot resolve those symbols. v26.05
linked this differently and passed 949/949.
Add fix_macos_test_python_link.patch, which links ${PYTHON_LIBRARIES}
into the test executables. Since a test target is an EXECUTABLE the
generator expression resolves to the Python library for it (and to
nothing for shared libraries), so the binaries load libpython and the
flat-namespace symbols resolve at runtime. Only the non-installed test
executables are affected; the shipped libraries are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the conda-forge-bot. The conda-forge-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/conda-forge/conda-forge-bot/actions/runs/29787859418 - please use this URL for debugging.