upgrade to v26.03 - #26
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict. Please ping the 'conda-forge/core' team (using the |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- fix the `add_pxr_install_dll_in_bin.patch` patch with 26.03 changes - in recipe: pin `cmake` and `libopensubdiv` packages, because in cmake file `find_package(OpenSubdiv 3 REQUIRED)` and `cmake_minimum_required(VERSION 3.26)`
|
@traversaro , thanks for the rerun of the bot on the bot PR. Do confirm if me creating a separate PR since I am not a maintainer is the right way to deal with it though. I am not familiar with such situation. After some patch fixes and other smaller changes, the Also, I saw the current issue #9 , but I am not sure to understand its subtilities and if anything is needed to be done during this |
|
Thanks for the work! Just a curiosity, are you using the
Yes, that is the correct way to go if you are not a maintainer and so you do not have write access to the autotick bot branches.
I guess I just needed to approve the job, it is now running.
That was fixed in #10, the issue is still open as we are missing a repodata patch to backport that fix for existing builds. |
| - tbb-devel | ||
| - libboost-devel | ||
| - libopensubdiv | ||
| - libopensubdiv 3.* |
There was a problem hiding this comment.
Is there any reason for this constraint?
There was a problem hiding this comment.
I added a pin because openusd cmake makes it as a searched pinned dep: https://github.com/PixarAnimationStudios/OpenUSD/blob/dae78ddbfe967ecedc2fd94da79d95a23e8b86f6/cmake/defaults/Packages.cmake#L221
Is that not correct ?
|
Thanks for the quick unlock of the github workflow and review !
I am currently using the c++ part, but planning to also use the python part in the future. Btw, on this, I usually build my recipes around split output to allow lower size installs and possibly not force python deps for those using only cpp side of things. For recipes like this one, is it possible to do a split after the fact without destroying the dependency chains ? Or is it now not possible ? (asking because if possible I could implement it in this PR ^ ^). |
Cool! If you like feel free to comment in PixarAnimationStudios/OpenUSD#3577 and PixarAnimationStudios/OpenUSD#3577 that this modifications (that are included here as patches) are also useful for you, thanks!
That is a good question. For C++/Python packages, my preferred methods for doing split C++/Python packages is to make sure that each part can be built on its own, see for example https://github.com/conda-forge/idyntree-feedstock/blob/main/recipe/recipe.yaml . Given the specific structure of the openusd build system, this is not possible, so for any kind of split attempt we would need to use https://rattler-build.prefix.dev/v0.58.4/py-rattler-build/tutorials/multi_output_and_staging/ or something similar (xref: conda/ceps#102), to which I am not really familiar and I am not even sure if it can be used now in conda-forge recipes. Even if that is possible, however, openusd is quite peculiar: it uses python headers in its public headers, so for sure we can't avoid depending on python in the core C++ In a nutshell, I think we could split the package in five outputs:
However, given the complexity of this, I would strongly prefer to do that in its own separate PR to simplify reviewing and debugging, instead of coupling this change with a version update PR. |
|
Thanks for the detailed answer @traversaro , Regarding the split, I have already tried the staging approach on local / private recipes. It works very well in those kind of setups. The five outputs look great to me at first glance. And I hadn't thought about it, but the split with an But I also agree that then it should be done in its own PR so I will try to revisit it once the stagging CEP is operational (I will do oiio/ocio first with them to get the hang of it ^ ^). So if you agree on the review nit that you mentioned previously on |
|
Hi @traversaro , Is there any blocker for merging now ? (I would like to experiment another build that has it as dependency over the weekend and there is some aspects in 26.03 that I would need) |
|
No! The 3.* pin on opensubdiv will need either a comment to be explained as it needs to be manually re-checked for consistency with the upstream CMakeLists.txt on every new release, but that is not blocking. |
|
Thanks a lot for the reviews, comments and maintenance of openusd ! I'll do a quick PR to add opensubdiv comment before I forget about it. Is something at the top of the file ok with you? Like : |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)