openimageio v3.1.14.1 - #155
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
| version: "3.1.14.1" | ||
| # https://github.com/AcademySoftwareFoundation/OpenColorIO/releases | ||
| ocio_version: "2.5.2" | ||
| build_number: 4 |
There was a problem hiding this comment.
@h-vetinari , this PR made me think on that, but :
isn't there a flaw in the recipe's logic when oiio is updated (and build-number reset) but not ocio ?
For example it seems we published 2 different 1 builds with different hash (probably corresponding to 2 oiio different versions that reset the build number):
- https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Flibopencolorio-2.5.2-ha05381d_1.conda
- https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux-64%2Flibopencolorio-2.5.2-h116e978_1.conda
Shouldn't we make a ocio_build_number separate from the oiio one ?
Or if there is a cleaner way with the staging / multi output I am interested in knowing it (otherwise supporting multiple version/build_number definitions and auto discovery of each by bot may be something to add in a future CEP/CFEP imo).
If that is ok with you, I can do a PR on that.
There was a problem hiding this comment.
Good observation, yes we should do that! :)
as discussed in #155 (comment) , the ocio output had a shared build number. Meaning when oiio updated and the global build number was reset ... ocio was also reset. Introduce a separate (not auto discovered by regro-bot) build number for ocio.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the conda-forge-bot. The conda-forge-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/conda-forge/conda-forge-bot/actions/runs/27527962523 - please use this URL for debugging.