onnxruntime v1.28.0 - #193
Merged
Merged
Conversation
regro-cf-autotick-bot
requested review from
cbourjau,
hmaarrfk,
janjagusch,
jtilly,
traversaro and
xhochy
as code owners
July 25, 2026 20:01
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/31238158371. Examine the logs at this URL for more detail. |
<details><summary>Claude's draft</summary>
Three recipe fixes needed for the 1.28.0 version bump:
- Refresh patches/0002-use-first-nvcc-found.patch: upstream added
flash_nvcc_threads lines above the CMAKE_CUDA_COMPILER append in
tools/ci_build/build.py, shifting the hunk context so the patch no
longer applied ("Hunk #1 FAILED at 730"); every CI job failed at the
source-patch step. The deleted line still exists, so only the context
needed regenerating.
- New patches/0006: test_adapter_export_rejects_string_tensors (new in
1.28.0) imports the onnx python package without the skipUnless guard
its sibling tests use; the recipe's host env has no onnx, so the
build-time test suite errored.
- New patches/0007: onnxruntime_test_python_autoep.py gained a
module-level "import onnx" in 1.28.0 (1.27.0 had none) but runs
before build.py's explicit "onnx is not installed" gate; make the
import optional and skip the two tests that use it.
All patches verified against the release tarball with patch -p1
--dry-run and git apply --check. Locally validated end to end:
linux_64 CPU py3.12 build compiles, the full build-time python test
suite passes, and both outputs package successfully. Patches 0006/0007
are candidates for upstreaming.
Resume this Claude session:
```
cd /home/mark/git/feedstock
claude --resume 11697c88-6bc5-4475-aea8-11a938bad00a
```
</details>
<details><summary>Claude's draft</summary>
The conda-forge linter flagged azure.free_disk_space and
azure.settings_win.variables.{SET_PAGEFILE,MINIFORGE_HOME,CONDA_BLD_PATH}
as deprecated in favor of workflow_settings. Rewritten exactly as
conda-smithy's internal auto-conversion maps them: everything scoped to
provider azure, SET_PAGEFILE 'True' -> pagefile_size 16 GiB,
free_disk_space true -> quick, and settings_linux.swapfile_size 10GiB
-> pagefile_size 10 on azure linux (same deprecation, migrated in the
same pass). Rendered CI behavior is unchanged: linux/win build on
GitHub Actions Namespace runners where these azure-scoped values never
applied, and osx on azure keeps the same quick disk cleanup. The azure
win settings are kept rather than dropped so they take effect again if
win ever moves back to Azure. Verified with conda-smithy's schema
validator: zero lints, zero hints.
Resume this Claude session:
```
cd /home/mark/git/feedstock
claude --resume 11697c88-6bc5-4475-aea8-11a938bad00a
```
</details>
…026.08.07.20.04.28 <details><summary>Claude's draft</summary> Other tools: - conda-build 26.7.0 - rattler-build 0.72.2 - rattler-build-conda-compat 1.4.18 Includes one manual correction on top of smithy's output: the executable bit on .scripts/free_disk_space.sh is restored. conda-smithy 2026.8.5 strips it from scripts added via workflow settings (fix pending in conda-forge/conda-smithy#2647), and the Azure osx jobs invoke the script directly, failing with Permission denied without it. Resume this Claude session: ``` cd /home/mark/git/feedstock claude --resume 11697c88-6bc5-4475-aea8-11a938bad00a ``` </details>
hmaarrfk
force-pushed
the
1.28.0_h5afafa
branch
from
August 8, 2026 03:51
d6d02c6 to
2ddc507
Compare
cbourjau
approved these changes
Aug 8, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Closes: #188
Closes: #189
Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the conda-forge-bot. The conda-forge-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/conda-forge/conda-forge-bot/actions/runs/30171875367 - please use this URL for debugging.