Convert to rattler-build recipe; make ghostscript an extra (optional dependency group) - #385
Draft
jonashaag wants to merge 1 commit into
Draft
Convert to rattler-build recipe; make ghostscript an extra (optional dependency group)#385jonashaag wants to merge 1 commit into
jonashaag wants to merge 1 commit into
Conversation
The permissive variants never link libgs; ghostscript is only an external delegate. Drop the hard run dependency for them and declare a 'ghostscript' optional dependency group instead, so gs-backed PDF/PS/EPS conversion becomes an explicit opt-in: imagemagick[extras=[ghostscript]]. The agpl variant keeps the unconditional run dependency. Blocked on repodata v3 support in conda-forge (conda/ceps#146). Closes conda-forgegh-326
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/recipe.yaml:
For recipe/recipe.yaml:
Documentation on acceptable licenses can be found conda-forge.org > Docs > Maintainer Documentation > Contributing packages > SPDX Identifiers and Expressions.
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/31179030685. Examine the logs at this URL for more detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use v3 repo data to ship Ghostscript as optional dependency
This converts the recipe to the rattler-build v1 format and uses the new repodata v3 optional dependency groups (CEP under vote, open until 2026-08-20) to make ghostscript an explicit opt-in for the permissive variants:
agplvariant: unchanged — keeps the unconditionalghostscriptrun dependency (it linkslibgs, which is what makes it AGPL).imagemagickvariant: no longer hard-depends onghostscriptat runtime. It never links libgs (the existing test asserts gslib is absent from delegates); gs was only used as an external delegate subprocess. Users who want gs-backed PDF/PS/EPS conversion opt in viaimagemagick[extras=[ghostscript]](or by installingghostscriptthemselves).Default solves are unaffected: the +100 build-number offset still makes solvers prefer the
agplvariant, which behaves exactly as before. Only users explicitly pinningbuild=imagemagick_*are affected, and for them shipping the AGPL gs binary implicitly arguably contradicts the point of that variant.Draft because:
requirements.extrasrequires rattler-build's--v3flag, which conda-forge does not enable yet. Rendering was validated locally withrattler-build build --render-only --v3againstconda_build_config.yaml; both variants render with the expected build strings (agpl_h*_101,imagemagick_h*_1), run dependencies, and the extras group. Once conda-forge rolls out v3 output this can be un-drafted and rerendered.Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)