Skip to content

Rebuild for CUDA 12 w/arch + python312 - #2

Merged
weiji14 merged 11 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-cuda120-0-3_h8aba38
May 9, 2024
Merged

Rebuild for CUDA 12 w/arch + python312#2
weiji14 merged 11 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:rebuild-cuda120-0-3_h8aba38

Conversation

@regro-cf-autotick-bot

@regro-cf-autotick-bot regro-cf-autotick-bot commented May 8, 2024

Copy link
Copy Markdown
Contributor

This PR has been triggered in an effort to update cuda120.

Besides that, the python312 migration from #3 has also been cherry-picked into this PR. Note that we have tried compiling for TORCH_CUDA_ARCH_LIST=8.0;8.6;8.9;9.0+PTX, but decided to stick with TORCH_CUDA_ARCH_LIST=8.0+PTX only to keep builds under CI limit of 6 hours as mentioned at #1 (comment)

This PR will thus result in 10 matrix builds on Linux for:

  • Python 3.8 to 3.12 (5 versions)
  • CUDA 11.8 and 12.0 (2 versions)

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and
build tools. Notably, the cudatoolkit package no longer exists, and packages
should depend directly on the specific CUDA libraries (libcublas, libcusolver,
etc) as needed. For an in-depth overview of the changes and to report problems
see this issue.
Please feel free to raise any issues encountered there. Thank you! 🙏


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8994039733 - please use this URL for debugging.

Closes #3

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and
build tools. Notably, the cudatoolkit package no longer exists, and packages
should depend directly on the specific CUDA libraries (libcublas, libcusolver,
etc) as needed. For an in-depth overview of the changes and to report problems
[see this issue]( conda-forge/conda-forge.github.io#1963 ).
Please feel free to raise any issues encountered there. Thank you! 🙏
@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@weiji14
weiji14 marked this pull request as draft May 8, 2024 01:35

@weiji14 weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, was wondering why there weren't any CUDA 12.0 builds in the initial feedstock. I've cherry-picked some of the commits from #1 into here, so we can test building on CUDA 11.8 and 12.0. If all the builds pass, we can close #1 and just merge #2.

Comment thread recipe/meta.yaml Outdated
weiji14 and others added 4 commits May 8, 2024 23:49
Try to reduce build time by not compiling explicitly for Hopper generation cards.
Reduce compilation time further to fit under 6 hours limit of Azure Pipelines CI.
@weiji14 weiji14 mentioned this pull request May 8, 2024
5 tasks
@weiji14 weiji14 changed the title Rebuild for CUDA 12 w/arch + Windows support Rebuild for CUDA 12 w/arch + python312 May 8, 2024
@weiji14 weiji14 self-assigned this May 8, 2024
@weiji14
weiji14 marked this pull request as ready for review May 8, 2024 20:15

@weiji14 weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, compiliation completed for TORCH_CUDA_ARCH_LIST=8.0+PTX in about 4 hours across all matrix builds. Gonna merge this in now!

@weiji14
weiji14 merged commit e0f080a into conda-forge:main May 9, 2024
@regro-cf-autotick-bot
regro-cf-autotick-bot deleted the rebuild-cuda120-0-3_h8aba38 branch May 9, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants