Skip to content

Add SPNEGO support - #56

Open
Tagar wants to merge 1 commit into
conda-forge:mainfrom
Tagar:patch-1
Open

Add SPNEGO support#56
Tagar wants to merge 1 commit into
conda-forge:mainfrom
Tagar:patch-1

Conversation

@Tagar

@Tagar Tagar commented May 28, 2019

Copy link
Copy Markdown

As proposed in #55

Thank you.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

As proposed in conda-forge#55 

Thank you.
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf

ocefpaf commented May 28, 2019

Copy link
Copy Markdown
Member

Can you add a test for that functionality?

@Tagar

Tagar commented May 28, 2019

Copy link
Copy Markdown
Author

@ocefpaf to test SPNEGO, I would need a spnego/kerberos-enabled web service to test that.. ideas if we have that available as part of CI?
Also, it's my first contribution here.. can you please send a pointer to some existing tests?
Thank you.

@ocefpaf

ocefpaf commented May 28, 2019

Copy link
Copy Markdown
Member

I was not thinking about an elaborated test like that 😄. Just a curl -V like you had in the issue and check for the appropriated string. It can be a command test in the recipe.

@jakirkham

Copy link
Copy Markdown
Member

Also this could use a build number bump 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants