Ensure all linter messages are originated from a LinterMessage - #2651
Open
soapy1 wants to merge 2 commits into
Open
Ensure all linter messages are originated from a LinterMessage#2651soapy1 wants to merge 2 commits into
LinterMessage#2651soapy1 wants to merge 2 commits into
Conversation
soapy1
commented
Aug 11, 2026
| """ | ||
|
|
||
| kind = "lint" | ||
| identifier = "R0-008" |
Author
There was a problem hiding this comment.
This can also apply to v1 recipes. Though, in practice (currently) this lint will only ever be added to a v0 recipe.
soapy1
marked this pull request as ready for review
August 11, 2026 16:05
soapy1
force-pushed
the
ensure-all-lints-have-LinterMessage
branch
from
August 11, 2026 16:05
174dbbd to
3d4defc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this pr is to ensure that all linter lints and hints have a
LinterMessagethat they originate from. This will ensure being able to output structured data for all lints/hints. All addedLinterMessagesare existing messages.LinterMessage:UnsupportedSchemaVersion- was previously a string appended to the list of lintsInvalidLicenseFamily- was previously wrapping a conda-build error as a string and adding it to the list of lintsTypeMustBeADictionary- was previously a string error messageTypeMustBeAListOrDictionary- was previously a string error messagesplit out from #2646
Checklist
newsentry with any new deprecations added to theDeprecatedsection.[ ] Regenerated schema JSON if schema altered (python -m conda_smithy.schema)python -m conda_smithy.linter.messages)