fix: context rendering with variant - #2544
Open
wolfv wants to merge 1 commit into
Open
Conversation
beckermr
requested changes
May 4, 2026
beckermr
left a comment
beckermr
left a comment
Member
There was a problem hiding this comment.
This needs a test and current tests are failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@baszalmstra found an issue converting the
vc-feedstockto v1 recipe. The context section requires some values coming from the variant definition.Rendering the context without the variant failed the rerendering.
This still needs some testing. Alternatively, we could be more lenient in
rattler-build-conda-compatand ignore lines in context that fail to render. Sister PR: conda-forge/rattler-build-conda-compat#121Checklist
newsentrypython -m conda_smithy.schema)python -m conda_smithy.linter.messages)