Skip to content

MAI: Remove AddNVIDIATools migrator - #6493

Merged
beckermr merged 5 commits into
conda-forge:mainfrom
carterbox:remove-nvtools-migrator
Aug 13, 2026
Merged

MAI: Remove AddNVIDIATools migrator#6493
beckermr merged 5 commits into
conda-forge:mainfrom
carterbox:remove-nvtools-migrator

Conversation

@carterbox

@carterbox carterbox commented Aug 13, 2026

Copy link
Copy Markdown
Member

Description:

Removes the AddNVIDIAToolks migrator which is no longer needed.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

Closes #6488

Reverts #3883

Comment on lines 91 to +94
ADD_NVIDIA_TOOLS = "AddNVIDIATools"
"""
This migrator is no longer present in the codebase but still appears in the graph.
"""

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these are the necessary updates to the pydantic model?

@carterbox
carterbox marked this pull request as ready for review August 13, 2026 18:21
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.92%. Comparing base (1b9f2ba) to head (cb8cdac).

Files with missing lines Patch % Lines
conda_forge_tick/migrators/core.py 50.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6493      +/-   ##
==========================================
+ Coverage   80.88%   80.92%   +0.03%     
==========================================
  Files         146      144       -2     
  Lines       17633    17508     -125     
==========================================
- Hits        14263    14168      -95     
+ Misses       3370     3340      -30     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beckermr
beckermr enabled auto-merge August 13, 2026 19:22
@beckermr
beckermr disabled auto-merge August 13, 2026 19:54
@beckermr
beckermr enabled auto-merge August 13, 2026 20:17
@beckermr
beckermr added this pull request to the merge queue Aug 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 13, 2026
@beckermr
beckermr added this pull request to the merge queue Aug 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 13, 2026
@beckermr
beckermr enabled auto-merge August 13, 2026 21:22
@beckermr
beckermr added this pull request to the merge queue Aug 13, 2026
Merged via the queue into conda-forge:main with commit 9903ab0 Aug 13, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can we close nvidiatoolsmigrator?

2 participants