Make win-arm64 and osx-arm64 migrators native - #6319
Draft
jaimergp wants to merge 2 commits into
Draft
Conversation
jaimergp
commented
Jul 16, 2026
jaimergp
changed the title
jaimergp
commented
Jul 16, 2026
| migrator_version = 1 | ||
| build_platform = {"osx_arm64": "osx_64"} | ||
| migrator_version = 2 | ||
| build_platform = {"osx_arm64": "osx_arm64"} |
Member
Author
There was a problem hiding this comment.
I think we can also clear this one because what matters is that arches defines the non-default provider.
jaimergp
commented
Jul 16, 2026
| allowed_schema_versions = {0, 1} | ||
| migrator_version = 1 | ||
| build_platform = {"osx_arm64": "osx_64"} | ||
| migrator_version = 2 |
Member
Author
There was a problem hiding this comment.
Do we need to bump this? Will this restart the migrator?
Member
There was a problem hiding this comment.
I don't think we want to bump this, because yes, new migrator_version cause everything in scope to be rebuilt; we don't want to rebuild all feedstocks that added osx-arm64 builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Once smithy 2026.7 is out, GHA will be the default CI provider for Windows x64 and arm64. This means we don't need to cross-compile. I want to avoid the migrator creating cross-compiling PRs when that happens. Is this the way to prevent that from happening? Or does it need a new migrator?
We can do the same with
osx-arm64, so I also added it here.Checklist:
Cross-refs, links to issues, etc: