Skip to content

CondaForgeYAMLCleanup: Extend to migrate to workflow_settings - #6240

Open
mgorny wants to merge 13 commits into
conda-forge:mainfrom
mgorny:workflow-settings
Open

CondaForgeYAMLCleanup: Extend to migrate to workflow_settings#6240
mgorny wants to merge 13 commits into
conda-forge:mainfrom
mgorny:workflow-settings

Conversation

@mgorny

@mgorny mgorny commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description:

Extend CondaForgeYAMLCleanup minimigrator to convert a variety of deprecated keys into their workflow_settings counterparts. In general, the logic assumes that unless Azure and GHA values are both present and mismatched, we make the existing value provider-independent. This both keeps the resulting file simpler by avoiding unnecessary conditions, and ensures that Azure settings clearly get migrated after as we switch more default providers to GHA.

(Submitting early as a draft to get feedback on the design before I go too deep into the rabbit hole.)

Checklist:

  • Pydantic model updated or no update needed

Tracking:

  • store_build_artifactsazure.store_build_artifacts, github_actions.store_build_artifacts
  • free_disk_spaceazure.free_disk_space, github_actions.free_disk_space
  • tools_install_dirazure.settings_win.variables.MINIFORGE_HOME
  • build_workspace_dirazure.settings_win.variables.CONDA_BLD_PATH
  • (top-level) docker.run_argsazure.settings_linux.variables.CONDA_FORGE_DOCKER_RUN_ARGS
  • pagefile_sizeazure.settings_linux.swapfile_size, azure.settings_win.variables.SET_PAGEFILE
  • resize_partitionsgithub_actions.resize_win_partitions

Cross-refs, links to issues, etc:

mgorny added 2 commits June 16, 2026 12:11
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>

@h-vetinari h-vetinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the overall idea!

Comment thread conda_forge_tick/migrators/conda_forge_yaml_cleanup.py
Comment thread tests/test_cfyaml_cleanup_migrator.py Outdated
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.52941% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.37%. Comparing base (0b0ae54) to head (c56e5d9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...a_forge_tick/migrators/conda_forge_yaml_cleanup.py 97.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6240      +/-   ##
==========================================
+ Coverage   81.23%   81.37%   +0.13%     
==========================================
  Files         146      146              
  Lines       17484    17612     +128     
==========================================
+ Hits        14204    14331     +127     
- Misses       3280     3281       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mgorny added 3 commits June 16, 2026 12:50
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
mgorny added 6 commits June 16, 2026 14:03
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
@mgorny
mgorny marked this pull request as ready for review June 16, 2026 14:39
@mgorny
mgorny marked this pull request as draft June 16, 2026 14:40
mgorny added 2 commits June 16, 2026 16:52
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
@mgorny
mgorny marked this pull request as ready for review June 16, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants