CondaForgeYAMLCleanup: Extend to migrate to workflow_settings - #6240
Open
mgorny wants to merge 13 commits into
Open
CondaForgeYAMLCleanup: Extend to migrate to workflow_settings#6240mgorny wants to merge 13 commits into
workflow_settings#6240mgorny wants to merge 13 commits into
Conversation
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
h-vetinari
reviewed
Jun 16, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6240 +/- ##
==========================================
+ Coverage 81.23% 81.37% +0.13%
==========================================
Files 146 146
Lines 17484 17612 +128
==========================================
+ Hits 14204 14331 +127
- Misses 3280 3281 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
22 tasks
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
mgorny
marked this pull request as ready for review
June 16, 2026 14:39
mgorny
marked this pull request as draft
June 16, 2026 14:40
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
mgorny
marked this pull request as ready for review
June 16, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Extend
CondaForgeYAMLCleanupminimigrator to convert a variety of deprecated keys into theirworkflow_settingscounterparts. In general, the logic assumes that unless Azure and GHA values are both present and mismatched, we make the existing value provider-independent. This both keeps the resulting file simpler by avoiding unnecessary conditions, and ensures that Azure settings clearly get migrated after as we switch more default providers to GHA.(Submitting early as a draft to get feedback on the design before I go too deep into the rabbit hole.)
Checklist:
Tracking:
store_build_artifacts←azure.store_build_artifacts,github_actions.store_build_artifactsfree_disk_space←azure.free_disk_space,github_actions.free_disk_spacetools_install_dir←azure.settings_win.variables.MINIFORGE_HOMEbuild_workspace_dir←azure.settings_win.variables.CONDA_BLD_PATHdocker.run_args←azure.settings_linux.variables.CONDA_FORGE_DOCKER_RUN_ARGSpagefile_size←azure.settings_linux.swapfile_size,azure.settings_win.variables.SET_PAGEFILEresize_partitions←github_actions.resize_win_partitionsCross-refs, links to issues, etc: