Conversation
5 tasks
memsharded
reviewed
Jul 7, 2026
AbrilRBS
changed the title
uilianries
approved these changes
Aug 14, 2026
uilianries
left a comment
uilianries
left a comment
Member
There was a problem hiding this comment.
LGTM
I've been using this feature for more than two weeks, and I made a few local changes to only generate/use .fish file (no .sh anymore) and it is working perfectly so far.
Feature of the year! 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add consumer support for Fish shells in conanrun/conanbuild files
Docs: TODO
The idea is that only final conanrun/conanbuild files should be able to be generated using fish, while the rest of the files for the dependency graph would still keep the usual sh approach