Add emsdk 6.0.6 - #13
Conversation
ba7bafc to
6c33cca
Compare
memsharded
left a comment
There was a problem hiding this comment.
Thanks very much for the contribution @fpelliccioni
Maybe this is doing too much, and might be split into 2 different PRs:
- One thing is the new version of emsdk, that needs some changes
- And a different one is the new CI check emsdk consistency script (pre commit hook)
Is the second one strictly necessary, or a convenience? Adding too much stuff to this repo CI is not planned, on the contrary, this repo should try to have a CI as lean as possible.
But just my opinion, @jcar87 might think differently
* Added emsdk/6.0.6 and updated profiles to match * Documented that wasm64 with emsdk 6 wants Conan 2.31.0+, which emits the modern -m64 instead of the deprecated -sMEMORY64 * emsdk 6.0.6 bundles node 24, so the wasm64 node caveat now applies to 5.x only
6c33cca to
a4ef13b
Compare
Fair point, split it. Force-pushed to a4ef13b, now just the 6.0.6 bump. The check and the hook are out, and .pre-commit-config.yaml is back to what's It was a convenience. No workflows in this repo, so it only ran if you had Checked by hand: profile 6.0.6, tool_requires 6.0.6, published in config.yml, |
emsdk/6.0.6alongside5.0.3, and updated the profiles to match it.compiler.versionand the[tool_requires]emsdk version in sync (Keepcompiler.versionand usedemsdkversion consistent #10).wasm64with emsdk 6 wants Conan 2.31.0+, which emits the modern-m64instead of the deprecated-sMEMORY64(Fix deprecation warning when building with emscripten 6.0.1 or higher conan#20152).required_conan_versionis left alone: the recipe is shared with5.0.3, where-sMEMORY64is still correct, andwasm32is unaffected.emsdk/6.0.6bundles node 24.19.0, so the wasm64 "install node 23+ by hand" caveat now applies to the 5.x series only.Checked from an empty
CONAN_HOMEwith Conan 2.31.2 on Linux x86_64:A probe binary built and ran with both profiles:
wasm32reportssizeof(void*)=4,wasm64reports8, using the SDK's own node and with no deprecation warning. The generatedconan_toolchain.cmakecarries-m64.5.0.7also exists upstream and is newer than the5.0.3here; left untouched to keep this to one version.