Add NotificationSummary class for structured, version-stamped inspection reports#353
Add NotificationSummary class for structured, version-stamped inspection reports#353CodyCBakerPhD with Copilot wants to merge 12 commits into
Conversation
- Add `NotificationSummary` class in `notifications/_notification_summary.py` with `__str__`, `to_json()`, and `to_file(path, aggregate=True)` methods - Export `NotificationSummary` from `notifications/__init__.py` and top-level `__init__.py` - Update `DatasetConverter.convert_to_bids_dataset()` to use `NotificationSummary` and write both `.json` and `.txt` report files - Update integration test to match new JSON structure (dict with version/run_id/notifications) - Add unit tests in `tests/unit/test_notification_summary.py` Co-authored-by: CodyCBakerPhD <51133164+CodyCBakerPhD@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
@copilot resolve the merge conflicts in this pull request to match your design |
The test was comparing the notifications JSON file contents against a bare list `[]`, but the format changed to a dict with nwb2bids_version, run_id, and notifications keys. Updated the assertion to match the new structure. Agent-Logs-Url: https://github.com/con/nwb2bids/sessions/d600b2c5-5586-4217-9b79-b65e50c3c7e4 Co-authored-by: CodyCBakerPhD <51133164+CodyCBakerPhD@users.noreply.github.com>
Resolved in afa2aa1. The merge conflict itself was already resolved in a prior merge commit, but the rebase onto main introduced a new test ( |
|
@copilot resolve the merge conflicts in this pull request |
…ion-summary-class # Conflicts: # src/nwb2bids/_converters/_dataset_converter.py # tests/integration/test_convert_nwb_dataset.py Co-authored-by: CodyCBakerPhD <51133164+CodyCBakerPhD@users.noreply.github.com>
Resolved in bb2e601. Merged the latest |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 85.42% 86.08% +0.65%
==========================================
Files 41 42 +1
Lines 1818 1947 +129
==========================================
+ Hits 1553 1676 +123
- Misses 265 271 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
NotificationSummaryclass insrc/nwb2bids/notifications/_notification_summary.pylist[Notification]and optionalrun_idas input__str__override with nice human-readable report (aggregates by identifier)to_json()returns full JSON string (all individual notifications, no aggregation)to_file(path, aggregate=True)writes to file (.jsonor.txtbased on suffix)NotificationSummaryfromnotifications/__init__.pyand top-level__init__.pyDatasetConverter.convert_to_bids_dataset()to useNotificationSummaryand write both.txtand.jsonfilestests/unit/test_notification_summary.py(15 tests)test_notifications.pyto match new JSON file structure and verify.txtreporttests/integration/test_convert_nwb_dataset.py::test_minimal_convert_nwb_dataset_from_directoryfor new JSON formatOriginal prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.