WOOF! Software USDC stream#985
Open
dmitriy-woof-software wants to merge 17 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+74
to
+80
| constructor(address _receiver) { | ||
| if(_receiver == address(0)) revert ZeroAddress(); | ||
|
|
||
| compOracleDecimals = AggregatorV3Interface(COMP_ORACLE).decimals(); | ||
| usdcOracleDecimals = AggregatorV3Interface(USDC_ORACLE).decimals(); | ||
| receiver = _receiver; | ||
| } |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.non-payable-constructor
Comment on lines
+100
to
+103
| if( | ||
| msg.sender != receiver && | ||
| block.timestamp < lastClaimTimestamp + 7 days | ||
| ) revert NotReceiver(); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-nested-if
| } | ||
|
|
||
| lastClaimTimestamp = block.timestamp; | ||
| suppliedAmount += owed; |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.inefficient-state-variable-increment
|
|
||
| lastClaimTimestamp = block.timestamp; | ||
| suppliedAmount += owed; | ||
| claimedCompAmount += compAmount; |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.inefficient-state-variable-increment
Comment on lines
+130
to
+133
| if( | ||
| msg.sender != COMPOUND_TIMELOCK && | ||
| block.timestamp < startTimestamp + STREAM_DURATION + 10 days | ||
| ) revert StreamNotFinished(); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-nested-if
MishaShWoof
force-pushed
the
woof-software/create-usdc-stream
branch
from
May 15, 2025 09:49
90ec56c to
1a4acd7
Compare
…ftware/comet into woof-software/create-usdc-stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.