fix(proto): resolve protolint line-length violations#582
Open
yvonnedevlinrh wants to merge 2 commits into
Open
fix(proto): resolve protolint line-length violations#582yvonnedevlinrh wants to merge 2 commits into
yvonnedevlinrh wants to merge 2 commits into
Conversation
Wrap long comments in api/plugin/plugin.proto to stay within the 80-character protolint limit. Add protolint:disable directives for the go_package option line (cannot be shortened) and the CONFIDENCE_LEVEL_NOT_SET enum value (deliberate naming choice per spec R29 for 1:1 mapping with go-gemara, not an _UNSPECIFIED case). Apply the same fixes to the spec contract proto. Generated Go code is unchanged — all fixes are proto comments only. This failure was pre-existing on main. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Yvonne Devlin <ydevlin@redhat.com>
Two comments in specs/.../contracts/plugin.proto exceeded the 80-character protolint limit (lines 36 and 74, both 84 chars). Wrap them to fix the remaining CI lint failure. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Yvonne Devlin <ydevlin@redhat.com>
em-redhat
approved these changes
Jun 12, 2026
trevor-vaughan
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrap long comments in
api/plugin/plugin.prototo stay within the 80-character protolint limit. Addprotolint:disabledirectives for thego_packageoption line (cannot be shortened) and theCONFIDENCE_LEVEL_NOT_SETenum value (deliberate naming choice per spec R29 for 1:1 mapping with go-gemara, not an_UNSPECIFIEDcase).Apply the same fixes to the spec contract proto.
Generated Go code is unchanged - all fixes are proto comments only.
This failure was pre-existing on main.
Related Issues
Review Hints
.protofiles are changed. No generated code, no Go source, no behavioral changes.protolint:disable:nextdirectives follow the same pattern already used inspecs/001-gemara-native-workflow/contracts/plugin.proto:10for thego_packageline.CONFIDENCE_LEVEL_NOT_SETname is intentionally preserved per spec R29 (specs/001-gemara-native-workflow/research.md:342) - go-gemara usesUndetermined(iota 0) as its zero value, while the proto usesNOT_SET(value 0) to distinguish "no confidence reported" from "confidence evaluated but undetermined."