Keep generated viewer offline by default - #24
Draft
YoungJinJung wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Cross-platform note: #27 adds the Windows/macOS/Linux CI matrix that should validate this change across supported operating systems before release. |
The generated topology viewer no longer loads Tailwind or D3 from remote CDNs. A small inline SVG renderer keeps the default report local-first and avoids executing unpinned third-party scripts when users open index.html. Constraint: Keep the generated report self-contained without adding dependencies. Rejected: Add SRI to CDN scripts | still makes local reports execute third-party code and require network access. Confidence: high Scope-risk: moderate Directive: Do not reintroduce remote script tags in default generated HTML without an explicit opt-in mode. Tested: npm test; node --check quarkify.mjs Related: #19
YoungJinJung
force-pushed
the
issue-19-offline-html
branch
from
June 16, 2026 07:44
a7e75c7 to
1fd1e2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.html.Closes #19.
Validation
npm testnode --check quarkify.mjs