Reject source paths outside srcDir - #22
Draft
YoungJinJung wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Cross-platform note: #27 adds the Windows/macOS/Linux CI matrix that should validate this change across supported operating systems before release. |
Source file entries now resolve under the canonical srcDir before Quarkify reads them. Traversal, absolute paths, and symlink escapes are rejected so generated output cannot accidentally materialize files outside the intended source tree. Constraint: Preserve existing relative and glob source file behavior. Rejected: Silently skip escaped paths | hiding configuration mistakes can still leak when paths are later corrected or symlinked. Confidence: high Scope-risk: moderate Directive: Keep source containment checks on both explicit and glob-resolved files. Tested: npm test; node --check quarkify.mjs Related: #17
YoungJinJung
force-pushed
the
issue-17-source-containment
branch
from
June 16, 2026 07:44
0c4fea6 to
66e39e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
srcDirand validate every explicit or glob-resolved source file before reading it.srcDir.../outside.jssource traversal.Closes #17.
Validation
npm testnode --check quarkify.mjs