Gate executable configs behind explicit opt-in - #21
Merged
Conversation
Contributor
Author
|
Cross-platform note: #27 adds the Windows/macOS/Linux CI matrix that should validate this change across supported operating systems before release. |
YoungJinJung
force-pushed
the
issue-16-safe-config
branch
from
June 16, 2026 07:44
12f0cb0 to
320281e
Compare
YoungJinJung
marked this pull request as ready for review
June 17, 2026 09:26
YoungJinJung
force-pushed
the
issue-16-safe-config
branch
from
August 1, 2026 04:02
320281e to
acbe89f
Compare
YoungJinJung
marked this pull request as draft
August 1, 2026 04:02
YoungJinJung
marked this pull request as ready for review
August 1, 2026 04:08
Quarkify now supports data-only JSON configs by default and requires --allow-executable-config before loading JavaScript configs that can run arbitrary local code. Documentation now steers shared configs toward JSON and labels executable configs as trusted-only. Constraint: Preserve custom guessRole workflows for trusted local users. Rejected: Remove JavaScript configs entirely | existing role-classification use cases depend on executable functions. Confidence: high Scope-risk: broad Directive: Keep non-executable config support as the default path for shared configuration. Tested: npm test; node --check quarkify.mjs Related: #16
YoungJinJung
force-pushed
the
issue-16-safe-config
branch
from
August 1, 2026 04:09
acbe89f to
341a9e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roleRules.--allow-executable-configbefore loading JavaScript configs, and verify rejected configs never execute.Closes #16.
Validation
npm test(15 passing)node --check quarkify.mjsnode --check skills/analyze/scripts/analyze.mjsgit diff --check