Repository navigation
fix(core): cut the child at the box in vector DecoratedBox - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vector
DecoratedBoxreported only its own box as its paint bounds, which cuts an overflowing child while the box is the rasterization root but not once the box sits inside another vector container: a vector parent keeps its children's nodes and drops their view boxes, so the child's overflow simply paints on. The raster variant clips in either position, because it composites the child into a box-sized buffer. Separately, the vector variant's ownborderstrokes the box outline, so half its width falls outside the box — and was cut off, the same omission #84 fixed for path shapes.Change
ClipGroupat the box, so aDecoratedBoxclips wherever it appears; a child that already fits emits the same node tree as before.paint_boundsandrender().view_box, since the border is the box's own paint rather than the child's.rect_path_commandswithClipinstead of rebuilding the box path.