Repository navigation
fix(core): include child overflow in vector container paint bounds - #93
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VectorLayer,Frame,Flex, andPaddingnever overrodeVectorComponent::paint_bounds, so they reported only their own(0,0)..sizelayout box while theirrenderreturned that same rectangle asview_box. The contract #84 enforces —view_box == paint_bounds— therefore held even though the bounds silently dropped whatever a child painted outside the box, and rasterization clipped it. The raster variants of all four have unioned their children's paint bounds into their own since #7; on the vector side onlyFragmentwas corrected in #84.Change
paint_boundson the vectorVectorLayer,Frame,Flex, andPaddingto start from(0,0)..sizeand union in every child's paint bounds, and return that same rectangle asrender().view_box.view_box == paint_boundsenforcement cannot see — and recordsDecoratedBoxandClipas the containers that pin their bounds on purpose.VectorLayer, covering the negative view-box origin.paint_boundsas a raster-side responsibility.