Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
HTTP custom-adapter configuration, public type compatibility, and Node runtime documentation need correction.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Migrates the onX reference server to MCP 2026-07-28 with SDK v2 and stateless HTTP serving.
Changes:
- Adds transport-neutral MCP runtime and
/mcpHTTP endpoint. - Migrates stdio and protocol error handling to SDK v2.
- Adds modern protocol integration tests and migration guidance.
| File | Description |
|---|---|
MCP_2026_07_28_MIGRATION.md |
Documents migration architecture and acceptance criteria. |
server/package.json |
Adds SDK v2 packages and requires Node 20. |
server/package-lock.json |
Locks new SDK dependencies. |
server/src/errors/error-adapter.ts |
Migrates error mapping to v2 types. |
server/src/errors/index.ts |
Migrates custom protocol errors. |
server/src/http-server.ts |
Adds stateless /mcp serving. |
server/src/index.ts |
Exports the new runtime factory. |
server/src/server.ts |
Introduces shared runtime and v2 stdio serving. |
server/src/types/mcp.ts |
Migrates MCP type aliases. |
server/tests/helpers/test-client.ts |
Adds modern protocol test support. |
server/tests/integration/mcp-http.test.ts |
Tests stateless HTTP behavior. |
server/tests/integration/server.test.ts |
Tests modern stdio discovery. |
Files not reviewed (1)
- server/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+82
to
+84
| package: process.env.ADAPTER_PACKAGE ?? config.adapter.package, | ||
| path: process.env.ADAPTER_PATH ?? config.adapter.path, | ||
| options: config.adapter.options, |
Comment on lines
+21
to
+22
| ProtocolError as McpError, | ||
| ProtocolErrorCode |
| }, | ||
| "engines": { | ||
| "node": ">=18.0.0" | ||
| "node": ">=20.0.0" |
|
@ajithkuriakose - Can you read over this update. Once you sign-off, we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the COF onX reference server to MCP 2026-07-28 serving semantics.
What changed
Validation
Deliberately out of scope