Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerates
schemas/tool-inputs/create-sales-order.jsonfrom its current Zod source.Why
#32 fixed the nested
order.customerfield increate-sales-order.ts(omitting server-generatedcreatedAt/updatedAt/tenantId) but never regenerated the JSON Schema output, so the committed file still reflected the pre-fix shape — requiring fields a client can't know. Found this while testing an unrelated schema fix (#53 ) — running the generator picked up this stale output too.How
Ran
npm run generate:json-schemaswith no source changes; diff is limited to thecustomerfield losing the 3 server-generated fields from itsproperties/required.Testing
npm run typecheck— cleannpm run lint— 0 errorsnpm test— 224/224 passing