fix(BE): add English names for all Belgian holidays - #665
Merged
Conversation
Adds `en` names to every Belgian holiday that only had fr/nl/de names, so requesting language `en` no longer falls back to French or Dutch for some entries. Names follow https://en.wikipedia.org/wiki/Public_holidays_in_Belgium (already cited in the file).
The 07-11 entry for VLG carried the French and German names of the Day of the Walloon Region (third Sunday of September). Use the names of the Flemish Community day per https://en.wikipedia.org/wiki/Public_holidays_in_Belgium.
kevinley
marked this pull request as ready for review
September 3, 2026 13:22
commenthol
added a commit
that referenced
this pull request
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Belgium declares
langs: [fr, nl, de]and several holidays only have local French, Dutch and German names. Asking forlanguages: 'en'gives a mixed list: shared names fromnames.yamlcome back in English, the local ones fall back to French or Dutch.This adds an
enname to every Belgian holiday that lacked one, following https://en.wikipedia.org/wiki/Public_holidays_in_Belgium (already cited in the file):easter 1easter 39easter 5008-1511-1111-1505-0811-1507-1109-27Second commit, separable: the Flemish Community day (
VLG,07-11) carried the French and German names of the Day of the Walloon Region. Corrected to Fête de la Communauté flamande / Feiertag der Flämischen Gemeinschaft per the same source.How to check
npm run yamlnode test/sample.js be 2026 --lang en --short, then the same forbe.bru,be.de,be.vlgandbe.wal. Every name comes back in English.npx mochapasses (5634 tests). Default-language output is unchanged, so no fixtures changed.