feat(RU): add regional holiday coverage - #659
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing the Russian holiday definitions in
opening_hours.jswith the existing Russian data indate-holidays, I noticed that the regional holidays were missing here.Rather than copying the existing
opening_hours.jsdata directly, I checked the underlying official legal sources. I used the ConsultantPlus overview to locate and cross-check the relevant laws and decrees, since some regional holidays are announced annually and their dates can change. I added only clearly supported non-working holidays and limited annually announced dates to specifically documented years.The known 2022 transfer days I also added.