fix(AX): use official Finnish/Åland sources, fix flag day types and casing - #655
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
@source(a supermarket's opening-hours page) with two proper sources: the University of Helsinki almanac office for the general Finnish holidays, and Åland's own flag law (landskapslag 1992:41 om Ålands flagga, §4) for the Åland-specific ones. Added Wikipedia's "Flaggdagar i Finland" as@attrib, since it helped confirm the flag day dates and their basis in that law.That law only classifies 03-30 and 06-09 as official flag days - neither the law nor Wikipedia mention any work-free status. Marked both as observance accordingly, and added the third flag day the law defines but which was missing here (Ålands flaggas dag, last Sunday in April). Also renamed 06-09 from "Självstyrelsedagen" to "Ålands självstyrelsedag" to match the law's wording.
Lowercased Midsommarafton/Midsommardagen too - the almanac source capitalizes them only in its headings (like a title), but writes them lowercase in running text, matching standard Swedish orthography for non-proper-noun holiday names.