Skip to content

ui: guard branch switcher before internet connected #38692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greatgitsby merged 2 commits into from
Aug 28, 2026
+3 −0
Merged

ui: guard branch switcher before internet connected #38692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
172a8a9
ui: guard branch switcher before internet connected
greatgitsby Aug 23, 2026
da3b2d9
Merge remote-tracking branch 'upstream/master' into HEAD
greatgitsby Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions openpilot/selfdrive/ui/mici/layouts/settings/software.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,9 @@ def _update_state(self):
self.set_value(target)

def _on_click(self):
if not ui_state.params.get("UpdaterAvailableBranches"):
gui_app.push_widget(BigDialog("", tr("Please connect to Wi-Fi to switch branches.")))

@sshane sshane Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better text would be "Failed to get available branches. Ensure you're connected to the internet and try again" in case it's a git/weird fork issue it's more accurate

@greatgitsby greatgitsby Aug 29, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#38732

fair

return
gui_app.push_widget(BranchSelectPage(self._on_select))

def _on_select(self, branch: str):
Expand Down
Loading