modeld: 2x faster chestnut build - #38656
Draft
adeebshihadeh wants to merge 7 commits into
Draft
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
Contributor
adeebshihadeh
changed the title
adeebshihadeh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMD only: 343s -> 175s (2x)all modeld: 523s -> 208s (2.5x)
most of that is AMD kernel compile, and there's still quite a bit more that can be done there. for example, the LLVM 20 we use on device is like 50% slower than LLVM 19 for some reasonremoved the parallel kernel compile in tinygrad. tinygrad will support this in the future, but today is not that day