Skip to content

ui: stack manager - #36642

Closed
greatgitsby wants to merge 28 commits into
commaai:masterfrom
greatgitsby:feat/stackmanager
Closed

ui: stack manager#36642
greatgitsby wants to merge 28 commits into
commaai:masterfrom
greatgitsby:feat/stackmanager

Conversation

@greatgitsby

@greatgitsby greatgitsby commented Nov 19, 2025

Copy link
Copy Markdown
Collaborator

move bespoke panel switching and bespoke modal handling into a single stack interface

likely going to break out changes from this, there are a few fundamental changes in this PR:

  • set_modal_overlay no longer needed, use stack
  • couple bugs found in keyboard renderer
  • "modal" operated differently than normal "widget" as it had a return code and handled it uniquely. want to make this a general feature of Widget.
  • i hate callback invoking pop, it should be simpler than this (dismiss should auto-handle pop if no action was taken)

@github-actions

github-actions Bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

raylib UI Preview

homescreen : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_paired : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_prime : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_unifont : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
homescreen_update_available : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
keyboard : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_full_alert : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_full_alert_long_text : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_full_alert_multiline : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
settings_network : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
settings_network_advanced : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
settings_software_branch_switcher : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
settings_software_release_notes : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

@sshane

sshane commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator

BTW a requirement for this kind of PR should be: easy to render the previous widget behind if swiping away

@adeebshihadeh adeebshihadeh mentioned this pull request Nov 30, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions Bot added the stale label Dec 22, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions Bot closed this Dec 29, 2025
@adeebshihadeh adeebshihadeh reopened this Dec 29, 2025
@github-actions github-actions Bot removed the stale label Dec 30, 2025

toggles_btn = BigButton("toggles", "", "icons_mici/settings/toggles_icon.png")
toggles_btn.set_click_callback(lambda: self._set_current_panel(PanelType.TOGGLES))
toggles_btn.set_click_callback(lambda: gui_app.stack.push(TogglesLayoutMici(back_callback=lambda: gui_app.stack.pop())))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this re-create the layouts each time?

def show_event(self):
super().show_event()
self._set_current_panel(None)
self._scroller.show_event()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need these show_events I think

@sshane

sshane commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Working on this in #37094

@greatgitsby

Copy link
Copy Markdown
Collaborator Author

superseded by #37094

@greatgitsby
greatgitsby deleted the feat/stackmanager branch February 21, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants