ui: stack manager - #36642
Closed
greatgitsby wants to merge 28 commits into
Closed
Conversation
greatgitsby
force-pushed
the
feat/stackmanager
branch
from
November 22, 2025 05:28
8b577e0 to
cd224cc
Compare
greatgitsby
force-pushed
the
feat/stackmanager
branch
from
November 24, 2025 19:26
52de36d to
4c23059
Compare
Collaborator
|
BTW a requirement for this kind of PR should be: easy to render the previous widget behind if swiping away |
Closed
Contributor
|
This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity. |
Contributor
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
sshane
reviewed
Feb 6, 2026
|
|
||
| toggles_btn = BigButton("toggles", "", "icons_mici/settings/toggles_icon.png") | ||
| toggles_btn.set_click_callback(lambda: self._set_current_panel(PanelType.TOGGLES)) | ||
| toggles_btn.set_click_callback(lambda: gui_app.stack.push(TogglesLayoutMici(back_callback=lambda: gui_app.stack.pop()))) |
Collaborator
There was a problem hiding this comment.
won't this re-create the layouts each time?
sshane
reviewed
Feb 6, 2026
| def show_event(self): | ||
| super().show_event() | ||
| self._set_current_panel(None) | ||
| self._scroller.show_event() |
Collaborator
There was a problem hiding this comment.
still need these show_events I think
Collaborator
|
Working on this in #37094 |
Collaborator
Author
|
superseded by #37094 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


































































move bespoke panel switching and bespoke modal handling into a single stack interface
likely going to break out changes from this, there are a few fundamental changes in this PR: