Add "quark run"#66
Draft
lv-develer wants to merge 1 commit into
Draft
Conversation
lv-develer
marked this pull request as draft
April 11, 2025 09:27
lv-develer
marked this pull request as ready for review
April 11, 2025 09:31
This adds each submodule's "bin" directory to the path and will make it easier to consume development tools that are downloaded by Quark (e.g. by using the "devdepends" table in `subprojects.quark` to e.g. download and use a project-specific version of CMake). The directory itself is configurable via the `quark_run_paths` option that accepts a list of module-relative paths that should be considered. Its default value is `["bin"]`, this way most packages will work out of the box by following the existing convention of putting executables in a `bin` directory. The current implementation currently considers all modules in the tree, in order to keep things simple (otherwise we'd have to add provenance information to all dependencies which would make this patch a bit more invasive). In the future we may want to consider only "devdepends" dependencies but we would like to play with this feature in real world scenarios first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds each submodule's "bin" directory to the path and will make it
easier to consume development tools that are downloaded by Quark (e.g.
by using the "devdepends" table in
subprojects.quarkto e.g. downloadand use a project-specific version of CMake).
The directory itself is configurable via the
quark_run_pathsoptionthat accepts a list of module-relative paths that should be considered.
Its default value is
["bin"], this way most packages will work out ofthe box by following the existing convention of putting executables in a
bindirectory.The current implementation currently considers all modules in the tree,
in order to keep things simple (otherwise we'd have to add provenance
information to all dependencies which would make this patch a bit more
invasive).
In the future we may want to consider only "devdepends" dependencies but
we would like to play with this feature in real world scenarios first.