Conversation
colorbox
commented
Jul 16, 2026
| int coinChange(vector<int>& coins, int amount) { | ||
| vector<int> coin_nums(amount + 1, numeric_limits<int>::max()); | ||
| coin_nums[0] = 0; | ||
| for (int to_coins = 1; to_coins <= amount; ++to_coins) { |
Owner
Author
There was a problem hiding this comment.
coinsだと、合計値を指すのか枚数を指すのかが不明瞭になるので別の名前を使うべきだった
h-masder
reviewed
Jul 16, 2026
| public: | ||
| int coinChange(vector<int>& coins, int amount) { | ||
| vector<long> coin_nums(amount + 1, numeric_limits<long>::max()); | ||
| coin_nums[0] = 0; |
There was a problem hiding this comment.
coin_numsは、コインの金額と解釈される可能性もありそうなので、num_coins、min_num_coinsあたりがいいかなと思いました。
h-masder
reviewed
Jul 16, 2026
| /* | ||
|
|
||
| Time Comprexity: O(n * m) (n: amount, m: coinsの長さ) | ||
| Space Complexity: O(n) |
There was a problem hiding this comment.
こちらをご確認ください
nodchip
reviewed
Jul 17, 2026
| int coinChange(vector<int>& coins, int amount) { | ||
| vector<long> coin_nums(amount + 1, numeric_limits<long>::max()); | ||
| coin_nums[0] = 0; | ||
| for (long i = 0; i <= amount; ++i) { |
There was a problem hiding this comment.
long はデータモデルによってビット数が変わります。
https://ja.wikipedia.org/wiki/64%E3%83%93%E3%83%83%E3%83%88#64%E3%83%93%E3%83%83%E3%83%88%E3%83%87%E3%83%BC%E3%82%BF%E3%83%A2%E3%83%87%E3%83%AB
原則避けたほうが無難だと思います。代わりに int64_t を使うことをお勧めいたします。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/coin-change/description/