fix(coverage): collect the shard from the workspace ext directory - #82
Merged
Conversation
Since get_workspace_dir learned to detect the compose-mounted /workspace (#78), pskel coverage captures into /workspace/ext/lcov.info (the host checkout) instead of the image's /ext. The coverage job still bind-mounted an empty host file over /ext/lcov.info and shipped it as the shard, which coverage-report rejected with "missing FNL: records". Drop the single-file mount and take the shard from ext/lcov.info. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Coverage / deploy-pagesfailure on main (Error: missing FNL: records in .../ubuntu-24.04-arm_8.5_cli_lcov.info).Root cause: since #78 taught
get_workspace_dirto detect the compose-mounted/workspace,pskel coveragecaptures into/workspace/ext/lcov.info— i.e. the host checkout'sext/lcov.info— instead of the image's/ext. The coverage job still bind-mounted an empty host file over/ext/lcov.infoand shipped that untouched empty file as the shard;pskel coverage-reportthen correctly rejected it at merge time.Fix: drop the
touch+ single-file bind mount and take the shard directly fromext/lcov.info(delivered via the standard workspace mount). Verified locally with the CI-shaped invocation: the host file contains full lcov 2.x records (FNL/FNA/FNF/FNH/DA); the newSF:/workspace/ext/...source paths resolve in the deploy-pages container through the same workspace mount.🤖 Generated with Claude Code