Repository navigation
test(runners): two tests no longer race a fast or a loaded runner - #47
Merged
Merged
Conversation
…den test The stand-in run ended at once, so on a fast runner the agent could settle it and remove its tree between the wait for the run and the read of its /data: ENOENT on test.csv in the release PR's CI. The run now waits for the read, as the sync test's run does.
…conds "Answered before the sixty-four megabytes were sent" was a 1.5 s bound, and six suites at once on one VM stretched it to 1.6–1.7 s in three runs of six. What the test means is that home does not drain the body: it now counts the chunks sent before the answer (24 of 1024 here; a socket's buffers hold a few megabytes, a drained body all of them) and keeps a 10 s bound against an answer that waits for a timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release PR's CI (#45) failed once on
a drain lets a held hidden-test run finish…(tests/runner-agent-lifecycle.test.mts):ENOENT … attempts/<id>/inputs/test.csv. The same test passed in #46's CI, on macOS and in a Linux node:22 run. A flake hunt on a Linux VM (the feature's 46 suites, six at once, three rounds) then caught a second one:an upload refused in the middle of its body is answered…(tests/remote-runners-doors.test.mts) took 1.6–1.7 s against a 1.5 s bound in three of six runs.What
seam.next = 'wait', thenseam.release()), as the sync test's run already does.Nothing outside the tests changes.