Skip to content

Remove unnecessary local storage (redux) for anonymous users - #38

Closed
tedw87 wants to merge 7 commits into
2.xfrom
remove-local-storage-for-anonymous
Closed

Remove unnecessary local storage (redux) for anonymous users#38
tedw87 wants to merge 7 commits into
2.xfrom
remove-local-storage-for-anonymous

Conversation

@tedw87

@tedw87 tedw87 commented Aug 5, 2025

Copy link
Copy Markdown
  • EU GDPR and Privacy related.

@ericof ericof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tedw87 Please adda a Changelog entry

@tedw87
tedw87 requested a review from ericof August 19, 2025 14:09
@avoinea

avoinea commented Aug 21, 2025

Copy link
Copy Markdown
Member

@tedw87 Can you please check the CI errors?

@avoinea
avoinea requested a review from ericof August 21, 2025 20:12
@avoinea
avoinea changed the base branch from 2.x to main September 10, 2025 08:50
@avoinea
avoinea changed the base branch from main to 2.x September 10, 2025 08:51
@avoinea
avoinea marked this pull request as draft September 10, 2025 10:45
@avoinea

avoinea commented Sep 10, 2025

Copy link
Copy Markdown
Member

@tedw87 Login doesn't seem to work anymore with this branch.

@tedw87

tedw87 commented Sep 12, 2025

Copy link
Copy Markdown
Author

The idea of cleaning up localStorage for anonymous users makes sense, but there’s a critical edge case:
If a user signs in mid-session, the middleware can remove the needed persisted state right before the auth flow finishes, breaking the login.
Also, the initial state appears even for anonymous users because Volto core creates the store and saves persistantReducers to localStorage at initialization, before any auth checks run.
Given these issues, we can’t merge this as-is. I’ll close the PR for now

@tedw87 tedw87 closed this Sep 12, 2025
@avoinea
avoinea deleted the remove-local-storage-for-anonymous branch September 13, 2025 13:53
@avoinea
avoinea restored the remove-local-storage-for-anonymous branch March 4, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants