Skip to content

fix(rockusb/nusb): Bulk reads should request a length that is a multiple of EP max packet size#62

Merged
sjoerdsimons merged 1 commit into
collabora:mainfrom
genkiinstruments:ep-in-multiple-of-max-packet-size
Jun 16, 2026
Merged

fix(rockusb/nusb): Bulk reads should request a length that is a multiple of EP max packet size#62
sjoerdsimons merged 1 commit into
collabora:mainfrom
genkiinstruments:ep-in-multiple-of-max-packet-size

Conversation

@dingari

@dingari dingari commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This change was present in #47 but seems to have been orphaned in the switch to nusb 0.2.

As per the nusb docs:

For an IN transfer, the buffer’s requested_len is the number of bytes requested. It must be a nonzero multiple of the endpoint’s maximum packet size or the transfer will fail with TransferError::InvalidArgument.

Confirmed to be an issue at least on macOS.

@sjoerdsimons sjoerdsimons added this pull request to the merge queue Jun 16, 2026
Merged via the queue into collabora:main with commit 2951c81 Jun 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants