abi(packr root): mirror Limits::default bump from packr-abi#25
Merged
Conversation
PR #23 bumped Limits::default in crates/pack-abi/src/lib.rs but the packr root crate (src/abi/mod.rs) has its own duplicate Limits struct and was missed. The downstream theater::pack_bridge::decode_value goes through packr::decode → packr::abi::Limits::default, so it kept seeing the pre-#23 limits and continued to reject ~1.3MB chain-event payloads with "Sequence too large at node 2". Mirror the same bump here so they stay in lockstep: - max_buffer_size: 16 MB → 256 MB - max_node_count: 1 M → 10 M - max_payload_size: 8 MB → 128 MB - max_sequence_len: 1 M → 128 M Follow-up: the two Limits structs should be consolidated — having packr re-export packr_abi::Limits would prevent this exact class of drift. Out of scope here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #23 bumped `Limits::default` in `crates/pack-abi/src/lib.rs`, but the packr root crate (`src/abi/mod.rs`) has its own duplicate `Limits` struct — and was missed. Downstream `theater::pack_bridge::decode_value` routes through `packr::decode → packr::abi::Limits::default`, so it kept seeing the pre-#23 limits and continued rejecting ~1.3MB chain-event payloads with "Sequence too large at node 2" (confirmed in prod deploy after #23 published).
Mirror the same bump here so they stay in lockstep:
Follow-up
Long-term, the two `Limits` structs should be consolidated — having packr re-export `packr_abi::Limits` would prevent this exact class of drift. Out of scope here; this is the operational unblock.
🤖 Generated with Claude Code