Unify temporary directory allocation strategy in tests#26
Open
KmoM88 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the upstream unification in
colcon/colcon-core#729, this PR refactors the test suite to use the moderntmp_pathfixture (which provides apathlib.Pathobject) instead of mixing multiple temporary directory strategies.Specifically, this package previously used:
tmpdirfixture (intest/test_environment_library_path.py)This refactor:
test/conftest.pycompatibility fixture fortmp_path(supporting older pytest versions, such as those on Enterprise Linux 8).test/test_environment_library_path.pyto usetmp_pathinstead oftmpdir.Pathimport and removes a redundantglobal spell_check_words_pathdeclaration intest/test_spell_check.pyto resolve pre-existing linter errors on modern environments.test/spell_check.wordsto include words introduced by the compatibility fixture (isdigit,itertools,linux,takewhile,tmpdir).Reference
Specifics
Unlike other submodules which used manual
TemporaryDirectoryblocks,colcon-library-pathonly used thetmpdirfixture.🤖 Assisted by Gemini