Skip to content

update next to v15 - #37

Open
kkuhnen wants to merge 2 commits into
coinbase:mainfrom
kkuhnen:kk/update-next
Open

update next to v15#37
kkuhnen wants to merge 2 commits into
coinbase:mainfrom
kkuhnen:kk/update-next

Conversation

@kkuhnen

@kkuhnen kkuhnen commented Nov 18, 2025

Copy link
Copy Markdown

This fixes a bug in the cdp-react lib with css import order:

Before After
Screenshot 2025-11-18 at 3 45 43 PM Screenshot 2025-11-18 at 3 53 14 PM
Screenshot 2025-11-18 at 3 45 58 PM Screenshot 2025-11-18 at 3 54 41 PM

@vercel

vercel Bot commented Nov 18, 2025

Copy link
Copy Markdown

@kkuhnen is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall

cb-heimdall commented Nov 18, 2025

Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@esteban-cb
esteban-cb self-requested a review November 19, 2025 14:10

@esteban-cb esteban-cb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vercel

vercel Bot commented Nov 19, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
onramp-demo-application Error Error Nov 19, 2025 2:12pm

@cb-heimdall

Copy link
Copy Markdown

Review Error for esteban-cb @ 2025-11-19 14:11:42 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@esteban-cb esteban-cb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix npm run build errors

09:10:51.035 Running build in Portland, USA (West) – pdx1
09:10:51.035 Build machine configuration: 4 cores, 8 GB
09:10:51.121 Cloning github.com/coinbase/onramp-demo-application (Branch: kk/update-next, Commit: b9c59d1)
09:10:51.648 Cloning completed: 526.000ms
09:10:52.414 Restored build cache from previous deployment (59RJJ6zHVCiY3ewcg4k4iKMLgWUe)
09:10:53.825 Running "vercel build"
09:10:54.200 Vercel CLI 48.10.3
09:10:54.337 WARN! Due to `builds` existing in your configuration file, the Build and Development Settings defined in your Project Settings will not apply. Learn More: https://vercel.link/unused-build-settings
09:10:54.472 Installing dependencies...
09:11:02.169 
09:11:02.169 added 7 packages, removed 4 packages, and changed 7 packages in 8s
09:11:02.170 
09:11:02.170 265 packages are looking for funding
09:11:02.170   run `npm fund` for details
09:11:02.184 Detected Next.js version: 15.4.3
09:11:02.190 Running "npm run build"
09:11:02.300 
09:11:02.300 > on-off-ramp-demo@0.1.0 build
09:11:02.300 > next build
09:11:02.300 
09:11:02.869    ▲ Next.js 15.4.3
09:11:02.869 
09:11:02.921    Creating an optimized production build ...
09:12:01.245  ✓ Compiled successfully in 58s
09:12:01.256    Skipping linting
09:12:01.256    Checking validity of types ...
09:12:01.524 
09:12:01.525    We detected TypeScript in your project and reconfigured your tsconfig.json file for you.
09:12:01.525    The following suggested values were added to your tsconfig.json. These values can be changed to fit your project's needs:
09:12:01.525 
09:12:01.525    	- target was set to ES2017 (For top-level `await`. Note: Next.js only polyfills for the esmodules target.)
09:12:01.525 
09:12:10.532 Failed to compile.
09:12:10.532 
09:12:10.532 ./app/api/apple-pay/order/route.ts:200:15
09:12:10.532 Type error: Property 'ip' does not exist on type 'NextRequest'.
09:12:10.532 
09:12:10.533 �[0m �[90m 198 |�[39m       request�[33m.�[39mheaders�[33m.�[39m�[36mget�[39m(�[32m'x-forwarded-for'�[39m)�[33m?�[39m�[33m.�[39msplit(�[32m','�[39m)[�[35m0�[39m]�[33m?�[39m�[33m.�[39mtrim() �[33m||�[39m
09:12:10.533  �[90m 199 |�[39m       request�[33m.�[39mheaders�[33m.�[39m�[36mget�[39m(�[32m'x-real-ip'�[39m) �[33m||�[39m
09:12:10.533 �[31m�[1m>�[22m�[39m�[90m 200 |�[39m       request�[33m.�[39mip�[33m;�[39m
09:12:10.533  �[90m     |�[39m               �[31m�[1m^�[22m�[39m
09:12:10.533  �[90m 201 |�[39m     
09:12:10.533  �[90m 202 |�[39m     �[90m// Check if IP is private or localhost and use a public test IP for development�[39m
09:12:10.533  �[90m 203 |�[39m     �[36mconst�[39m isPrivateIp �[33m=�[39m �[33m!�[39mclientIp �[33m||�[39m �[0m
09:12:10.580 Next.js build worker exited with code: 1 and signal: null
09:12:10.690 Error: Command "npm run build" exited with 1

@cb-heimdall

Copy link
Copy Markdown

Review Error for esteban-cb @ 2025-11-19 14:14:57 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants